Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename JobType from on-demand to workflow_dispatch #11243

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Rename JobType from on-demand to workflow_dispatch #11243

merged 7 commits into from
Jul 5, 2024

Conversation

Sawthis
Copy link
Contributor

@Sawthis Sawthis commented Jul 4, 2024

Description

Changes proposed in this pull request:

  • Rename JobType from on-demand to workflow_dispatch as it is better to have the same value for JobType as github event name. It's easier to maintain and use in tests of image builder on ADO.

Related issue(s)

#10987

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2024
IwonaLanger
IwonaLanger previously approved these changes Jul 4, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 4, 2024
KacperMalachowski
KacperMalachowski reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@KacperMalachowski KacperMalachowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIngle comment to consider (maybe even discuss in the team), overall LGTM.

pkg/azuredevops/pipelines/templatesParams.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 5, 2024
KacperMalachowski
KacperMalachowski approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@KacperMalachowski KacperMalachowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 5, 2024
@kyma-bot kyma-bot merged commit 0b2e601 into kyma-project:main Jul 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KacperMalachowski KacperMalachowski KacperMalachowski approved these changes

@IwonaLanger IwonaLanger IwonaLanger left review comments

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@NHingerl NHingerl Awaiting requested review from NHingerl

@grego952 grego952 Awaiting requested review from grego952

@nataliasitko nataliasitko Awaiting requested review from nataliasitko

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@akiioto akiioto Awaiting requested review from akiioto akiioto is a code owner automatically assigned from kyma-project/prow

Assignees

@KacperMalachowski KacperMalachowski

@IwonaLanger IwonaLanger

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sawthis @KacperMalachowski @IwonaLanger @kyma-bot