Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug logging for generating tags #12088

Merged
merged 21 commits into from
Oct 15, 2024

Conversation

dekiel
Copy link
Contributor

@dekiel dekiel commented Oct 6, 2024

Description

Changes proposed in this pull request:

Functions generating tags got debug severity logging statements. The debug flag will enable logger with debug severity. Debug messages will increase troubleshooting ability for the process of generating tags.

To make debug logging compatible with oci-image-builder pipeline, generated tags are written to the file instead to the stdout. The pipeline will read tags from file independent from tool standard or error output.

Related issue(s)
See #10415

Added validation tag field to provide validation regex together with a tag.
Update kaniko-build-config.yaml to provide default tag for pr and commit images with validation regex.
Validating tag when parsing it's value.
Added TagOption to add PR number to the Tagger instance.
Using pull request default tag together with user provided tags instead replacing all values with default tag. This allows users to provide their own tag to the images build on pr.
Write parsed tags to file.
Added writing generated tags to the file. This let us write logs in to stdout because the generated tags can be read from file.
Write parsed tags to file.
Added writing generated tags to the file. This let us write logs in to stdout because the generated tags can be read from file.
…logging-for-ustom-tags

# Conflicts:
#	cmd/image-builder/main.go
…to debug-logging-for-ustom-tags

# Conflicts:
#	cmd/image-builder/config.go
#	cmd/image-builder/main.go
#	pkg/tags/options.go
#	pkg/tags/tag.go
#	pkg/tags/tags.go
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2024
@dekiel dekiel self-assigned this Oct 6, 2024
Use logger from options when building locally.
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 6, 2024

Plan Result

CI link

No changes. Your infrastructure matches the configuration.

@dekiel dekiel marked this pull request as ready for review October 6, 2024 12:25
@dekiel dekiel requested review from neighbors-dev-bot and a team as code owners October 6, 2024 12:25
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2024
@dekiel dekiel added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. image-builder labels Oct 6, 2024
@dekiel dekiel removed their assignment Oct 6, 2024
@dekiel dekiel removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 15, 2024
@kyma-bot kyma-bot merged commit 4bf19f3 into kyma-project:main Oct 15, 2024
52 checks passed
@dekiel dekiel deleted the debug-logging-for-ustom-tags branch October 15, 2024 13:19
@dekiel dekiel assigned dekiel and unassigned akiioto Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. image-builder lgtm Looks good to me! no-changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants