Debug logging for generating tags #12088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added validation tag field to provide validation regex together with a tag. Update kaniko-build-config.yaml to provide default tag for pr and commit images with validation regex. Validating tag when parsing it's value. Added TagOption to add PR number to the Tagger instance. Using pull request default tag together with user provided tags instead replacing all values with default tag. This allows users to provide their own tag to the images build on pr.
Write parsed tags to file.
Added writing generated tags to the file. This let us write logs in to stdout because the generated tags can be read from file.
Write parsed tags to file.
Added writing generated tags to the file. This let us write logs in to stdout because the generated tags can be read from file.
…logging-for-ustom-tags # Conflicts: # cmd/image-builder/main.go
…to debug-logging-for-ustom-tags # Conflicts: # cmd/image-builder/config.go # cmd/image-builder/main.go # pkg/tags/options.go # pkg/tags/tag.go # pkg/tags/tags.go
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
Use logger from options when building locally.
Plan Result |
kyma-bot
removed
the
do-not-merge/work-in-progress
dekiel
added
do-not-merge/hold
…logging-for-ustom-tags
Added logging in other packages used by image-builder
dekiel
removed
the
do-not-merge/hold
akiioto
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Functions generating tags got debug severity logging statements. The debug flag will enable logger with debug severity. Debug messages will increase troubleshooting ability for the process of generating tags.
To make debug logging compatible with oci-image-builder pipeline, generated tags are written to the file instead to the stdout. The pipeline will read tags from file independent from tool standard or error output.
Related issue(s)
See #10415