Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify autobumpers in test-infra repository #12134

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Unify autobumpers in test-infra repository #12134

merged 3 commits into from
Oct 16, 2024

Conversation

KacperMalachowski
Copy link
Contributor

Description

Image autobumper has own bumper implementation, this PR propose to unify it.

Changes proposed in this pull request:

  • Update existing bumper to accept GHES host
  • Update image autobumper to use exisitng implementation
  • Remove duplicated implementation

Related issue(s)

See: #12056

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 11, 2024
@KacperMalachowski KacperMalachowski marked this pull request as ready for review October 11, 2024 13:45
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
@KacperMalachowski
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@KacperMalachowski KacperMalachowski marked this pull request as draft October 11, 2024 13:57
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
@KacperMalachowski
Copy link
Contributor Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@KacperMalachowski KacperMalachowski marked this pull request as ready for review October 11, 2024 14:22
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 16, 2024
@kyma-bot kyma-bot merged commit d3a2e3e into kyma-project:main Oct 16, 2024
102 checks passed
@dekiel dekiel assigned KacperMalachowski and unassigned akiioto Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akiioto akiioto akiioto approved these changes

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@Sawthis Sawthis Awaiting requested review from Sawthis Sawthis is a code owner automatically assigned from kyma-project/prow

@szumejker szumejker Awaiting requested review from szumejker szumejker is a code owner automatically assigned from kyma-project/prow

Assignees

@KacperMalachowski KacperMalachowski

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KacperMalachowski @kyma-bot @akiioto