Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unexposed jwt_secret on GET /api/kytos/core/config/ endpoint #378

Merged
merged 4 commits into from
May 3, 2023
Merged

fix: Unexposed jwt_secret on GET /api/kytos/core/config/ endpoint #378

merged 4 commits into from
May 3, 2023

Conversation

viniarck
Copy link
Member

Closes #370

This PR is on top of #375

Summary

See updated changelog file

Local Tests

Request body diff before and after:

❯ diff respb.md respa.md
3c3
< content-length: 1019
---
> content-length: 971
5c5
< date: Mon, 24 Apr 2023 19:36:38 GMT
---
> date: Mon, 24 Apr 2023 19:49:06 GMT
21d20
<     "jwt_secret": "8ece86b575c347e69bb8823936be9512",

End-to-End Tests

N/A

@viniarck viniarck requested a review from a team as a code owner April 24, 2023 20:01
Base automatically changed from feat/starlette to master May 3, 2023 17:23
@viniarck viniarck merged commit e444933 into master May 3, 2023
@viniarck viniarck deleted the fix/secret_vul branch May 3, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security vulnerability /api/kytos/core/config is exposing options.jwt_secret
1 participant
@viniarck