This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
add keyboard interrupt to create_napp #291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hdiogenes , we are getting the same error as last time for test_napps, but we do not understand how adding a simple try-except to handle a KeyboardInterrupt is causing the test to fail. Any advice on this? |
Removed try-except block surrounding the entire create_napps function. Instead, we created 3 try-except blocks surrounding the user inputs, which are: username, napps_name, and description
|
We were able to fix the errors causing test_napps to fail and tested our implementation to confirm that it works. Now, we are going to resolve the pylint errors. |
hdiogenes
requested review from
a team,
cmagnobarbosa and
josemauro
and removed request for
a team
cmagnobarbosa
approved these changes
Sep 3, 2020
josemauro
approved these changes
Sep 8, 2020
|
This PR is being closed and the modifications are being adjusted in #318 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Capstone 1 team at FIU attempted to solve issue #212 , in which we simply solved by catching a KeyboardInterrupt exception on create_napp()
This is a redo of the 2nd part of pull request #284 . We solved this issue during the beginning of the semester. At the time, our team didn't know how to use Github properly and how to go about creating pull requests. This time, we created a separate branch that changes to fix only issue #212 .