Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow null in empty object assertion #430

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

eddycharly
Copy link
Member

Explanation

Disallow null in empty object assertion.

Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.75%. Comparing base (c06867b) to head (ac6c77a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   22.10%   22.75%   +0.64%     
==========================================
  Files          85       85              
  Lines        3415     3419       +4     
==========================================
+ Hits          755      778      +23     
+ Misses       2586     2562      -24     
- Partials       74       79       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JimBugwadia
JimBugwadia previously approved these changes Jul 21, 2024
Copy link
Member

@JimBugwadia JimBugwadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add unit tests to cover this case?

Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@eddycharly eddycharly requested a review from JimBugwadia July 21, 2024 20:42
@eddycharly eddycharly merged commit 61c433c into kyverno:main Jul 21, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants