Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-444): add kernel list into session detail drawer #3081

Open
wants to merge 2 commits into
base: feat/session-idle-checker-in-detail-panel
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Feb 3, 2025

resolves #3075 (FR-444)

Adds a Kernel List to the Session Detail Drawer where you can view kernel information.

Feature:

  • The showKernelList variable in config.toml allows you to set the visibility of the kernel list in the session detail drawer.
  • The Session Detail Panel shows a list of kernels connected to the session.

How to test:

  • Depending on the settings in config.toml, you can set the visibility of the kernel list.
  • You can check the session id in the container commit modal or log modal, and access the session detail drawer with the query string ?sessionDetail=<session_id>.
  • Verify that the kernel information is displayed correctly for single node / multi node session.

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author

ironAiken2 commented Feb 3, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC labels Feb 3, 2025
@ironAiken2 ironAiken2 force-pushed the feat/kernel-list-in-session-detail branch from a30f17c to 4a89ec4 Compare February 3, 2025 09:11
Copy link

github-actions bot commented Feb 3, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.84% (-0.06% 🔻)
398/8230
🔴 Branches
4.18% (-0.06% 🔻)
239/5720
🔴 Functions
2.92% (-0.03% 🔻)
78/2669
🔴 Lines
4.76% (-0.06% 🔻)
383/8052
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / SessionIdleChecks.tsx
0% 0% 0% 0%
🔴
... / ConnectedKernelList.tsx
0% 0% 0% 0%
🔴
... / IdleCheckDescriptionModal.tsx
0% 100% 0% 0%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 helper/index.tsx
43.14% (-9.87% 🔻)
37.62% (-7.08% 🔻)
37.78% (-3.69% 🔻)
43.17% (-11.31% 🔻)

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 91241d1

@ironAiken2 ironAiken2 marked this pull request as ready for review February 3, 2025 09:19
@ironAiken2 ironAiken2 changed the title feat: add kernel list into session detail drawer feat(FR-444): add kernel list into session detail drawer Feb 3, 2025
@ironAiken2 ironAiken2 force-pushed the feat/kernel-list-in-session-detail branch from 4a89ec4 to 91241d1 Compare February 4, 2025 11:02
@ironAiken2 ironAiken2 changed the base branch from main to feat/session-idle-checker-in-detail-panel February 4, 2025 11:02
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel list in Session Detail panel
2 participants