-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FR-444): add kernel list into session detail drawer #3081
base: feat/session-idle-checker-in-detail-panel
Are you sure you want to change the base?
feat(FR-444): add kernel list into session detail drawer #3081
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
a30f17c
to
4a89ec4
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 4.84% (-0.06% 🔻) |
398/8230 |
🔴 | Branches | 4.18% (-0.06% 🔻) |
239/5720 |
🔴 | Functions | 2.92% (-0.03% 🔻) |
78/2669 |
🔴 | Lines | 4.76% (-0.06% 🔻) |
383/8052 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / SessionIdleChecks.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / ConnectedKernelList.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / IdleCheckDescriptionModal.tsx |
0% | 100% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | helper/index.tsx | 43.14% (-9.87% 🔻) |
37.62% (-7.08% 🔻) |
37.78% (-3.69% 🔻) |
43.17% (-11.31% 🔻) |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 91241d1
4a89ec4
to
91241d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
resolves #3075 (FR-444)
Adds a Kernel List to the Session Detail Drawer where you can view kernel information.
Feature:
showKernelList
variable in config.toml allows you to set the visibility of the kernel list in the session detail drawer.How to test:
?sessionDetail=<session_id>
.Checklist: (if applicable)