broken test adjustment

laboratoriobridge · Sep 23, 2024 · 0152abb · 0152abb
1 parent 7ffa763
commit 0152abb
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 18 deletions.
diff --git a/src/components/Combobox/ComboboxMultiselect.test.tsx b/src/components/Combobox/ComboboxMultiselect.test.tsx
@@ -544,21 +544,28 @@ describe('async loading', () => {
 })
 
 describe('filtering', () => {
-  it('should clear the current filter and the input value after menu is closed', async () => {
-    const { container } = render(<ComboboxTest />)
-    const input = container.querySelector('input')!
-
-    fireEvent.focus(input)
-    fireEvent.change(input, { target: { value: 'pe' } })
-
-    await waitFor(() => expect(container.querySelectorAll('li')).toHaveLength(4))
-
-    fireEvent.click(container.querySelectorAll('li')[0])
-    fireEvent.blur(input)
-
-    expect(container.querySelectorAll('li')).toHaveLength(0)
-    expect(input.value).toEqual('')
-  })
+  test.each`
+    clearFilterOnSelect
+    ${true}
+    ${false}
+  `(
+    'should clear the current filter and the input value after menu is closed (clearFilterOnSelect: $clearFilterOnSelect)',
+    async ({ clearFilterOnSelect }) => {
+      const { container } = render(<ComboboxTest clearFilterOnSelect={clearFilterOnSelect} />)
+      const input = container.querySelector('input')!
+
+      fireEvent.focus(input)
+      fireEvent.change(input, { target: { value: 'pe' } })
+
+      await waitFor(() => expect(container.querySelectorAll('li')).toHaveLength(4))
+
+      fireEvent.click(container.querySelectorAll('li')[0])
+      fireEvent.blur(input)
+
+      expect(container.querySelectorAll('li')).toHaveLength(0)
+      expect(input.value).toEqual('')
+    }
+  )
 
   it('should clear the current filter and the input value after an item is selected if clearFilterOnSelect is true', async () => {
     const { container } = render(<ComboboxTest clearFilterOnSelect={true} />)

diff --git a/src/components/Combobox/ComboboxMultiselect.tsx b/src/components/Combobox/ComboboxMultiselect.tsx
@@ -280,9 +280,7 @@ function comboboxMultiselectStateReducer<T>(
     case useCombobox.stateChangeTypes.InputBlur:
       return {
         ...changes,
-        ...(!changes.selectedItem && {
-          inputValue: '',
-        }),
+        inputValue: '',
       }
     default:
       return changes