Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#823 [Combobox] - Treating select issues #853

Merged
merged 6 commits into from
Sep 24, 2024
Merged

#823 [Combobox] - Treating select issues #853

merged 6 commits into from
Sep 24, 2024

Conversation

Andrevmatias
Copy link
Contributor

closes #823

@Andrevmatias Andrevmatias marked this pull request as ready for review September 20, 2024 21:18
@Andrevmatias Andrevmatias linked an issue Sep 20, 2024 that may be closed by this pull request
Implement tests for each bug/problem found for the Select component #823
Closed
10 tasks
diegoasmello
diegoasmello approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@diegoasmello diegoasmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Andrevmatias Andrevmatias merged commit 52b576d into combobox Sep 24, 2024
2 checks passed
@Andrevmatias Andrevmatias deleted the 823-combobox-treating-select-issues branch September 24, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoasmello diegoasmello diegoasmello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement tests for each bug/problem found for the Select component
2 participants
@Andrevmatias @diegoasmello