Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20187 - Disponibilizar os thrifts e xmls novos no esusab-integracao #120

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

alisson-fs
Copy link

closes laboratoriobridge/pec#20187

@alisson-fs alisson-fs marked this pull request as ready for review May 24, 2024 20:15
Copy link
Contributor

@wagnerbsantos wagnerbsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajustar o circunferencia abdominal em alguns lugares.
Gerar alguns arquivos dnv com base no branch onde o circunferência abdominal está corrigido.
Remover alguns arquivos do pr que não alterou nada (não marquei todos)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esse aqui da pra tirar do pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tirar do pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tirar do pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tirar do pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tirar do pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gerar dnv

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gerar dnv

@@ -108,3 +108,20 @@ struct ResultadosExameThrift {
4:optional i64 dataResultado;
6:optional list<ResultadoExameThrift> resultadoExame;
}

struct MedicoesThrift {
1:optional double circuferenciaAbdominal;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1:optional double circuferenciaAbdominal;
1:optional double circunferenciaAbdominal;

XSD/medicoes.xsd Outdated

<xs:complexType name="medicoesTransport">
<xs:sequence>
<xs:element minOccurs="0" name="circuferenciaAbdominal" type="xs:double"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element minOccurs="0" name="circuferenciaAbdominal" type="xs:double"/>
<xs:element minOccurs="0" name="circunferenciaAbdominal" type="xs:double"/>

@@ -136,6 +134,21 @@
<hipoteseDiagnosticoCid10>O03</hipoteseDiagnosticoCid10>
<classificacaoRisco>1</classificacaoRisco>
</encaminhamentos>
<medicoes>
<circuferenciaAbdominal>50.0</circuferenciaAbdominal>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<circuferenciaAbdominal>50.0</circuferenciaAbdominal>
<circunferenciaAbdominal>50.0</circunferenciaAbdominal>

Ajustar o circunferencia abdominal nos exemplos

@alisson-fs
Copy link
Author

Retirei alguns arquivos do PR e fiz alguns ajustes com base nos comentários do Wag. A geração dos arquivos é feita através de um .sh que existe no repositório esusab-integracao, então não faria diferença regerar após o versionamento.

thrift/layout-ras/thrift/ficha_atendimento_odonto.thrift Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que essa não muda depois da https://github.com/laboratoriobridge/pec/issues/20950

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ela deve ter os campos depreciados sim, o problema da issue é que um atendimento individual estava enviando as medições tanto na FAI quanto na FP, sendo que deveria ser só na FAI
Se for um atendimento de procedimentos com o CBO que só preenche a FP, as medições devem ir na FP daí ;)

@alisson-fs alisson-fs removed the request for review from GuilhermePrandi May 28, 2024 20:11
Copy link

@romulofer romulofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Esse deu trabalho kkkkkk

@romulofer romulofer removed their assignment Jun 3, 2024
@nathanmolinari nathanmolinari self-requested a review June 3, 2024 17:22
@glaucio-martins glaucio-martins removed their assignment Jun 3, 2024
@zDudaHang
Copy link

@wagnerbsantos, acho que vale ver com o @nathanmolinari se ele vai revisar ainda ou deixamos travado no teste

Comment on lines -32 to -33
8:optional double pesoAcompanhamentoNutricional;
9:optional double alturaAcompanhamentoNutricional;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que faltou arrumar os números no thrift, confirma @nathanmolinari ? Ou mantemos assim porque o CN ainda mapeia com esses números?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depois de arrumar os número, tem que regerar os Thrift.java, tá?

Copy link

@GuilhermePrandi GuilhermePrandi Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pelo o que olhei ele mapeia por esses números, tanto que tem alguns campos que pulam números, por campos que já foram depreciados, então não precisaria corrigir

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Após confirmação com o Nathan, não precisa corrigir a ordenação, esse mapeamento ainda vai valer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ela deve ter os campos depreciados sim, o problema da issue é que um atendimento individual estava enviando as medições tanto na FAI quanto na FP, sendo que deveria ser só na FAI
Se for um atendimento de procedimentos com o CBO que só preenche a FP, as medições devem ir na FP daí ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants