-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move outline to glsl #92
Conversation
It seems I've broken the rendering of the pie-chart centroids (OR-mode). |
Ah, it seems centroids are broken before my changes:
|
I've filed the OR-mode bug as a separate issue. I'll see if switching centroid mode to WebGL solves that problem. Solved my issue with centroids!:
|
I've marked this PR as ready for review... I can handle the centroid rendering in another PR. |
I've moved more of the logic to the shaders... there's one more (edit: two more )more rendering optimization(s) I'd like to make before reviewing for the merge. Edit: Also, there's a rendering issue for pie-charts when rendering 4+ markers. |
I've solved the pie chart issue for 4+ markers... there is still an optimization on the ordering of selection kesy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the image viewer so that it doesn't render images when the gating parameters are loading from the server. One last step may be to add a loading icon so the users know when the client is waiting on the server.
I've moved the outline rendering from the canvas to WebGL with modifications to the fragment shader.