-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(cdk): expose cache to components (#1441)
* feat(GROW-2498): expose cache to components * chore(goimports): change imports-check from go list to find The previous imports-check target uses `go list` to find code to scan. The problem is that `go list` produces a listing of directories to input into goimports. /a/b/c /a/b/c/d /a/b/c/e ---> example we want to exclude In the example listing above, we want to exclude `e`. That was previously done by excluding `e` via a `grep -v` command that followed `go list`. The result is that the path with `e` on the end is excluded, but `/a/b/c` is still scanned causing the excluded path to get scanned anyway. This commit swaps all this out for a find command that excludes the paths and returns filenames as input, not directories. * chore: add ci build of go-component test resources * chore: add integration test binaries back These can be refreshed using the make cdk-go-component-ci command, however it'll cause local integration tests to fail unless folks rebuild these manually everytime on their machines. In addition, its slowing the integration tests down substantially on an already long-running job. These resources should be fairly static so we're making the choice to include these resources statically. * refactor: update cdk cache interface based on feedback
- Loading branch information
Matt Cadorette
authored
Dec 14, 2023
1 parent
5b898f7
commit af026bb
Showing
17 changed files
with
579 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,4 +32,3 @@ override.tf.json | |
*_override.tf | ||
*_override.tf.json | ||
*.terraform.lock.hcl | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.