Added return type to the AbstractFacade method.

lagdo · Sep 27, 2024 · 57e4df1 · 57e4df1
1 parent 7ac8710
commit 57e4df1
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -39,7 +39,7 @@ class MyFacade extends AbstractFacade
     /**
      * @inheritDoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return MyService::class;
     }
@@ -114,7 +114,7 @@ class View extends AbstractFacade
     /**
      * @inheritdoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return \Twig\Environment::class;
     }
@@ -172,7 +172,7 @@ class TaggedServiceFacade extends AbstractFacade
     /**
      * @inheritdoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return TaggedService::class;
     }
@@ -218,7 +218,7 @@ class MyFacade extends AbstractFacade
     /**
      * @inheritDoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return MyService::class;
     }

diff --git a/composer.json b/composer.json
@@ -13,11 +13,11 @@
         "source": "https://github.com/lagdo/symfony-facades"
     },
     "require": {
+        "php": ">=7.4.0",
         "psr/container": ">=1.0.0",
         "symfony/framework-bundle": "5.*|6.*|7.*"
     },
     "require-dev": {
-        "php": ">=7.0.0",
         "phpunit/phpunit": "^9.5",
         "symfony/phpunit-bridge": "^5.4",
         "symfony/test-pack": "^1.0",

diff --git a/src/AbstractFacade.php b/src/AbstractFacade.php
@@ -9,7 +9,7 @@ abstract class AbstractFacade
      *
      * @return string
      */
-    abstract protected static function getServiceIdentifier();
+    abstract protected static function getServiceIdentifier(): string;
 
     /**
      * Get the service instance.

diff --git a/src/Log.php b/src/Log.php
@@ -22,7 +22,7 @@ final class Log extends AbstractFacade
     /**
      * @inheritDoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return LoggerInterface::class;
     }

diff --git a/src/View.php b/src/View.php
@@ -61,7 +61,7 @@ final class View extends AbstractFacade
     /**
      * @inheritdoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return Environment::class;
     }

diff --git a/tests/Facades/Instance/PrivateServiceFacade.php b/tests/Facades/Instance/PrivateServiceFacade.php
@@ -12,7 +12,7 @@ class PrivateServiceFacade extends AbstractFacade
     /**
      * @inheritdoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return PrivateServiceInterface::class;
     }

diff --git a/tests/Facades/Instance/PublicServiceFacade.php b/tests/Facades/Instance/PublicServiceFacade.php
@@ -12,7 +12,7 @@ class PublicServiceFacade extends AbstractFacade
     /**
      * @inheritdoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return PublicServiceInterface::class;
     }

diff --git a/tests/Facades/PrivateServiceFacade.php b/tests/Facades/PrivateServiceFacade.php
@@ -10,7 +10,7 @@ class PrivateServiceFacade extends AbstractFacade
     /**
      * @inheritdoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return PrivateServiceInterface::class;
     }

diff --git a/tests/Facades/PublicServiceFacade.php b/tests/Facades/PublicServiceFacade.php
@@ -10,7 +10,7 @@ class PublicServiceFacade extends AbstractFacade
     /**
      * @inheritdoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return PublicServiceInterface::class;
     }

diff --git a/tests/Facades/TaggedServiceFacade.php b/tests/Facades/TaggedServiceFacade.php
@@ -10,7 +10,7 @@ class TaggedServiceFacade extends AbstractFacade
     /**
      * @inheritdoc
      */
-    protected static function getServiceIdentifier()
+    protected static function getServiceIdentifier(): string
     {
         return TaggedService::class;
     }