-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Generate Maven Archetype #60
base: 1.6.x
Are you sure you want to change the base?
Conversation
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
3de958f
to
6d6522d
Compare
6d6522d
to
ab113b0
Compare
Also, I created PR foundweekends/giter8#432. With this feature template for Maven Archetype can will more elegant 😄 |
Hi @ihostage, thanks for all the effort you've put into this but I see multiple problems. In the past we thought a single code base with multiple targets was a good idea and it always ended up being a wrong assumption. We tried making a single code base work in both Maven and sbt, we also tried making a single code base deployable to multiple targets (DC/OS-Marathon, Kubernetes,...) and things always get hairy fast. The Hello World code base is small and stable enough that keeping duplicates is not a big pain. Actually, I think we haven't made any significant change for around 2 years. But the main issue I see is moving the maven archetype code and publishing away from
Maven users should not need to install Having said all this, is there any use case you had in mind that motivates this convergence? |
@ignasi35 You absolutely right 😉 My hight-level proposal maybe writes as:
By the way, Hello World for Maven and Sbt are different now 😄 Sbt template has not integration tests. |
Anyway, exploring this idea I implemented one feature for G8 and this already no zero result 😂 |
It's PoC inspired by a phrase of Renato "and the whole idea is to reduce Lagom’s code base" © 😄
My idea is that has only one template for Hello Java example.
We can use Giter8 for generating Lagom Maven Archetype and remove the very similar files from https://github.com/lagom/lagom/tree/master/dev/archetypes/maven-java/src/main/resources.
@renatocaval @ignasi35 @marcospereira @dwijnand What do you think?