Convert relocation table to HashMap<usize, MaybeRelocatable> #1862
+52
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the relocation table to
MaybeRelocatables in order to support intsDescription
Fixes #1860.
This PR converts the relocation table from a
HashMap<usize, Relocatable>to aHashMap<usize, MaybeRelocatable>in order to support integers.The original
add_relocation_rulefns have been left untouched so that they still only supportRelocatables and a newfn add_relocation_rule_maybe_relocatable()has been added to support using aMaybeRelocatable. This should prevent this change from affecting most users.See #1860 for more details on the motivation for this change.
Description of the pull request changes and motivation.
Checklist