Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert relocation table to HashMap<usize, MaybeRelocatable> #1862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

notlesh
Copy link

@notlesh notlesh commented Oct 30, 2024

Convert the relocation table to MaybeRelocatables in order to support ints

Description

Fixes #1860.

This PR converts the relocation table from a HashMap<usize, Relocatable> to a HashMap<usize, MaybeRelocatable> in order to support integers.

The original add_relocation_rule fns have been left untouched so that they still only support Relocatables and a new fn add_relocation_rule_maybe_relocatable() has been added to support using a MaybeRelocatable. This should prevent this change from affecting most users.

See #1860 for more details on the motivation for this change.

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory operations should sometimes accept an Integer
1 participant