Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more type and mutability checks #124

Merged
merged 1 commit into from
May 9, 2024
Merged

Add more type and mutability checks #124

merged 1 commit into from
May 9, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented May 7, 2024

Checks if a variable is declared mutable and if not, if its being mutated.

Checks for valid mutable borrows (but doesnt check for multiple mutable borrows yet).

image

image

Copy link

github-actions bot commented May 7, 2024

Benchmarking factorial

Compiling factorial (factorial.con)
Finished release in 29.635568ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 59.21 ms
Rust Result = 2432902008176640000 Time taken : 60.12 ms

Benchmarking fib

Compiling fib (fib.con)
Finished release in 25.358815ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 136.23 ms
Rust Result = 6765 Time taken : 85.19 ms

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 58.92857% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 58.44%. Comparing base (bd93e07) to head (bfc07ea).

Files Patch % Lines
crates/concrete_check/src/lib.rs 0.00% 40 Missing ⚠️
crates/concrete_ir/src/lib.rs 87.50% 4 Missing ⚠️
crates/concrete_ir/src/lowering.rs 95.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   58.64%   58.44%   -0.20%     
==========================================
  Files          25       25              
  Lines        4258     4361     +103     
==========================================
+ Hits         2497     2549      +52     
- Misses       1761     1812      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanbono juanbono added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit e0e6fb2 May 9, 2024
5 checks passed
@juanbono juanbono deleted the more_mut_checks branch May 9, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants