Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concrete IR #88

Merged
merged 61 commits into from
Feb 20, 2024
Merged

Add concrete IR #88

merged 61 commits into from
Feb 20, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Feb 1, 2024

Simplifies codegen for both MLIR and C

IR documentation rendered: https://github.com/lambdaclass/concrete/blob/mir/docs/IR.md

@edg-l edg-l changed the base branch from main to parse_floats_chars_string_unescape February 1, 2024 18:31
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 705 lines in your changes are missing coverage. Please review.

Comparison is base (e9ac0c9) 60.51% compared to head (77828be) 59.05%.

Files Patch % Lines
crates/concrete_codegen_mlir/src/codegen.rs 62.92% 294 Missing ⚠️
crates/concrete_ir/src/lowering.rs 80.84% 154 Missing ⚠️
crates/concrete_ir/src/lowering/prepass.rs 65.80% 93 Missing ⚠️
crates/concrete_codegen_mlir/src/lib.rs 56.52% 60 Missing ⚠️
crates/concrete_driver/src/lib.rs 0.00% 43 Missing ⚠️
crates/concrete_ir/src/lib.rs 50.60% 41 Missing ⚠️
crates/concrete_ir/src/lowering/common.rs 78.04% 9 Missing ⚠️
crates/concrete_codegen_mlir/src/context.rs 85.96% 8 Missing ⚠️
crates/concrete_check/src/lib.rs 0.00% 2 Missing ⚠️
crates/concrete_codegen_mlir/src/errors.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   60.51%   59.05%   -1.46%     
==========================================
  Files          29       34       +5     
  Lines        1674     3136    +1462     
==========================================
+ Hits         1013     1852     +839     
- Misses        661     1284     +623     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from parse_floats_chars_string_unescape to main February 6, 2024 14:49
@edg-l edg-l marked this pull request as ready for review February 13, 2024 16:04
@unbalancedparentheses
Copy link
Member

@juanbono @igaray please review it

@igaray igaray merged commit 93603d7 into main Feb 20, 2024
4 checks passed
@igaray igaray deleted the mir branch February 20, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants