feat(l1): implement EIP-2935 #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2025 16:41
|
fborello-lambda
approved these changes
Feb 6, 2025
mpaulucci
reviewed
Feb 11, 2025
crates/blockchain/payload.rs
Outdated
| // This function applies system level operations: | ||
| // - Call beacon root contract, and obtain the new state root | ||
| // - Call block hash process contract, and store parent block hash | ||
| pub fn apply_system_operations(context: &mut PayloadBuildContext) -> Result<(), EvmError> { | ||
| #[cfg(feature = "levm")] |
There was a problem hiding this comment.
levm ff doesn't exist anymore, pls sync with main before merging
mpaulucci
reviewed
Feb 11, 2025
crates/blockchain/payload.rs
Outdated
| @@ -270,6 +269,7 @@ pub fn apply_withdrawals(context: &mut PayloadBuildContext) -> Result<(), EvmErr | |||
| .unwrap_or(EVMConfig::canonical_values(fork)); | |||
| let config = EVMConfig::new(fork, blob_schedule); | |||
|
|
|||
| let mut new_state: HashMap<_, _> = HashMap::new(); | |||
There was a problem hiding this comment.
nit: why specify the type at all if you are using underscores?
mpaulucci
reviewed
Feb 11, 2025
crates/blockchain/payload.rs
Outdated
|
|
||
| context.block_cache.extend(new_state); | ||
| new_state.extend(report.new_state.clone()); |
There was a problem hiding this comment.
seems we're doing a lot of cloning. Are all these cheap?
mpaulucci
reviewed
Feb 11, 2025
crates/vm/vm.rs
Outdated
| @@ -153,6 +157,62 @@ cfg_if::cfg_if! { | |||
|
|
|||
| } | |||
|
|
|||
| /// Calls the EIP-2935 process block hashes history system call contract | |||
There was a problem hiding this comment.
There are two possibilities.
- Ideally, we can abstract the logic between levm/revm and implement
process_block_hash_history, agnostic of the implementation of the vm (levm or revm). - If 1 is impossible, we should at least have a
levmandrevmfolder or module were we specify these implementations.
mpaulucci
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This EIP has to be implemented in order to support Prague update.
Description
This PR implements EIP-2935. Prague EF tests for this EIP have been enabled.
Closes #1786