Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(l2): bump revm + sp1 #1960

Merged
merged 31 commits into from
Feb 19, 2025
Merged

chore(l2): bump revm + sp1 #1960

merged 31 commits into from
Feb 19, 2025

Conversation

fkrause98
Copy link
Contributor

@fkrause98 fkrause98 commented Feb 14, 2025

Motivation

We need a new version of REVM for some changes.

Description

  • Bump revm to version 19.
  • Bump revm's dependencies.
  • Bump sp1 to v4.
  • This breaks risc0 support, since revm 19 needs rust 1.82, and risc0 supports up-to rust 1.81.

@fkrause98 fkrause98 requested a review from a team as a code owner February 14, 2025 16:10
@fkrause98 fkrause98 changed the title [DO NOT MERGE] chore(prover): bump revm [DO NOT MERGE] chore(vm,l2,prover): bump revm Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

| File                                                                         | Lines | Diff |
+------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/zkvm/interface/build.rs     | 15    | +7   |
+------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/utils/prover/save_state.rs         | 437   | +1   |
+------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/backends/revm.rs                   | 457   | -24  |
+------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/opcode_handlers/system.rs | 718   | -3   |
+------------------------------------------------------------------------------+-------+------+

Total lines added: +8
Total lines removed: 27
Total lines changed: 35

@fkrause98 fkrause98 changed the title [DO NOT MERGE] chore(vm,l2,prover): bump revm chore(l1,l2,vm): bump revm Feb 17, 2025
@fkrause98 fkrause98 changed the title chore(l1,l2,vm): bump revm chore(l1,l2,vm): bump revm + sp1 Feb 17, 2025
@fkrause98 fkrause98 changed the title chore(l1,l2,vm): bump revm + sp1 chore(l2): bump revm + sp1 Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 238.0 ± 0.7 237.2 239.5 1.00
levm_Factorial 909.0 ± 9.2 899.2 923.7 3.82 ± 0.04

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.483 ± 0.097 1.366 1.629 1.00
levm_FactorialRecursive 15.651 ± 0.102 15.487 15.757 10.55 ± 0.70

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 210.5 ± 1.2 209.2 213.3 1.00
levm_Fibonacci 901.9 ± 14.5 887.2 927.4 4.29 ± 0.07

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.7 ± 0.1 8.6 8.8 1.00
levm_ManyHashes 18.2 ± 0.2 17.9 18.6 2.09 ± 0.03

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.266 ± 0.017 3.244 3.293 1.00
levm_BubbleSort 6.076 ± 0.022 6.036 6.116 1.86 ± 0.01

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 252.4 ± 0.9 251.1 253.9 1.00
levm_ERC20Transfer 541.8 ± 6.4 534.4 556.4 2.15 ± 0.03

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 142.9 ± 0.6 142.2 144.0 1.00
levm_ERC20Mint 353.6 ± 2.6 350.7 357.3 2.48 ± 0.02

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.044 ± 0.004 1.039 1.051 1.00
levm_ERC20Approval 2.032 ± 0.007 2.023 2.044 1.95 ± 0.01

Main Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 244.0 ± 10.1 238.5 272.5 1.00
levm_Factorial 906.1 ± 8.2 896.1 918.5 3.71 ± 0.16

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.464 ± 0.080 1.392 1.616 1.00
levm_FactorialRecursive 15.657 ± 0.093 15.489 15.779 10.70 ± 0.59

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 211.0 ± 0.5 209.9 211.5 1.00
levm_Fibonacci 915.7 ± 38.0 888.6 1017.7 4.34 ± 0.18

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.7 ± 0.1 8.6 8.8 1.00
levm_ManyHashes 18.1 ± 0.2 17.9 18.5 2.09 ± 0.03

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.294 ± 0.027 3.258 3.341 1.00
levm_BubbleSort 6.086 ± 0.041 6.048 6.176 1.85 ± 0.02

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 256.1 ± 2.0 254.3 260.6 1.00
levm_ERC20Transfer 542.3 ± 2.3 540.1 547.5 2.12 ± 0.02

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 144.0 ± 1.4 142.3 146.6 1.00
levm_ERC20Mint 354.5 ± 2.7 351.5 359.3 2.46 ± 0.03

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.066 ± 0.006 1.060 1.079 1.00
levm_ERC20Approval 2.053 ± 0.038 2.014 2.125 1.93 ± 0.04

Copy link
Contributor

@JulianVentura JulianVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments

Copy link
Contributor

@fborello-lambda fborello-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fkrause98 fkrause98 added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit ef1352b Feb 19, 2025
46 checks passed
@fkrause98 fkrause98 deleted the bump-revm branch February 19, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants