-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(l1): modularize sync code & add doc comments for each module #1961
Merged
+1,183
−1,031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…y-healing' into reorganize-sync-code
…y-healing' into reorganize-sync-code
…y-healing' of github.com:lambdaclass/lambda_ethereum_rust into parallel-state-sync-rebuild-in-background-refactor-early-healing
…y-healing' into reorganize-sync-code
mpaulucci
approved these changes
Feb 17, 2025
MarcosNicolau
approved these changes
Feb 17, 2025
Base automatically changed from
parallel-state-sync-rebuild-in-background-refactor-early-healing
to
main
February 17, 2025 18:48
…to reorganize-sync-code
mpaulucci
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The code for sync has grown significantly since its start, and having it all under the same module can make it very hard to follow.
This PR aims to solve this by separating each different job into different modules and adding module-level documentation for each, explaining how each part of the sync works and integrates to the system as a whole
Description
Notes for merging:
This PR will likely conflict with #1936 but it has the same exact code, only moving it across modules, so it should be safe to solve all conflicts by keeping the changes from this PR alone. Alternatively, you can also merge this PR into #1936 as it has no conflicts and then merge #1936