Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync aggregate block addition #1288

Merged
merged 15 commits into from
Sep 13, 2024
Merged

Conversation

rodrigo-o
Copy link
Collaborator

@rodrigo-o rodrigo-o commented Sep 9, 2024

Motivation

This PR add sync_aggregate to our blocks to complete the sync committee spect

Description

The last step in adding the whole sync committees functionality to our node is to add sync aggregates at block proposal. This PR handles starting listening to the contributions topic and generating the aggregate at the block builder step. [Link to the spec]

Closes #917

@rodrigo-o rodrigo-o changed the title Sync aggregate block addition feat: sync aggregate block addition Sep 9, 2024
@rodrigo-o rodrigo-o marked this pull request as ready for review September 12, 2024 23:19
@rodrigo-o rodrigo-o requested a review from a team as a code owner September 12, 2024 23:19
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/lambda_ethereum_consensus/utils.ex Outdated Show resolved Hide resolved
Co-authored-by: Tomás Arjovsky <[email protected]>
@rodrigo-o rodrigo-o enabled auto-merge (squash) September 13, 2024 16:03
@rodrigo-o rodrigo-o merged commit a2f2a28 into main Sep 13, 2024
13 checks passed
@rodrigo-o rodrigo-o deleted the sync-aggregate-block-addition branch September 13, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Collect sync commitee contributions and include sync_aggregate in a block
2 participants