Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Eigen DA Merge Main #290

Merged
merged 101 commits into from
Oct 8, 2024
Merged

Conversation

gianbelinche
Copy link

@gianbelinche gianbelinche commented Oct 4, 2024

What ❔

This PR updates eigen da with latest changes from main
Related to lambdaclass/era-contracts#39
Some changes to make this work:

The try_load_config in add_da_client_layer in core/bin/zksync_server/src/node_builder.rs was moved inside the match for avail, since we don't have that config for eigenda.
Updated sql query cache files.

Both rollup and validium were checked to be working
Now when running zk_inception ecosystem init the following fields should not be present anymore:

  • --prover-db-url=postgres://postgres:notsecurepassword@localhost:5432
  • --prover-db-name=zksync_prover_localhost_eigen_da

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

artmakh and others added 30 commits September 18, 2024 08:03
…bs#2901)

## What ❔

Remove use of ZK tool in docker-build process

## Why ❔

Improve readability of CI, speeds up building process

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

- Resolves "nonce too low" errors on L1 by retrying transaction
requests. This is a temporary measure until a new version of `reth` is
released.
- Reduces spammy logs for integration tests. Enables verbose output for
integration tests in CI.
- Fixes some other issues with tests (e.g., a data race in the snapshot
recovery test).

## Why ❔

Makes CI more stable.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.

Signed-off-by: Danil <[email protected]>
## What ❔

Workflow to build base-image

## Why ❔

Added ability to push to ghcr.io

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

Fix multiarch command for build-base-image CI

## Why ❔


## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

Change build-base image location from dockerhub to ghcr.io

## Why ❔

Workaround for dockerhub rate-limiting 

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

This PR is the first part of [this
one](matter-labs#2631).

We decided to separate it into smaller PRs to make it easier to read and
review.

This PR contains only the changes to the `TransactionData` structs for
the different VM versions, modifying them for an optional field.

The other parts are currently available in our repo fork, as they are
based on this branch. The other PRs are:
- [feat: evm simulator as base system
contract](#256):
integrates the EVM interpreter contract as a base system contract and
includes all necessary updates for zksync-era to run with it.
- [feat: make evm simulator optional for the
server](#257): makes the
evm simulator optional to run using a config file.

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

Introduce WitnessGenerator trait
Rename some methods

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

Following Anton's suggestion, we have switched to hex serialization for
API/RPC requests and responses. Previously, we used default JSON
serialization for Vec<u8>, which resulted in a lengthy comma-separated
list of integers.

This change standardizes serialization, making it more efficient and
reducing the size of the responses. The previous format, with a series
of comma-separated integers for pubkey-like fields, looked odd.

Then:
```
curl -X POST\
     -H "Content-Type: application/json" \
     --data '{"jsonrpc": "2.0", "id": 1, "method": "unstable_getTeeProofs", "params": [491882, "sgx"] }' \
        https://mainnet.era.zksync.io
{"jsonrpc":"2.0","result":[{"attestation":[3,0,2,0,0,0,0,0,10,<dozens of comma-separated integers here>
```

Now:
```
$ curl -X POST \
       -H "Content-Type: application/json" \
       --data '{"jsonrpc": "2.0", "id": 1, "method": "unstable_getTeeProofs", "params": [1, "sgx"] }' \
          http://localhost:3050
{"jsonrpc":"2.0","result":[{"l1BatchNumber":1,"teeType":"sgx","pubkey":"0506070809","signature":"0001020304","proof":"0a0b0c0d0e","provedAt":"2024-09-16T11:53:38.253033Z","attestation":"0403020100"}],"id":1}
```

This change needs to be deployed in lockstep with:
matter-labs/teepot#209.

## Why ❔

To improve user experience (UX) and optimize the RPC response size.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.

Co-authored-by: Artem Makhortov <[email protected]>
## What ❔

Adding image which will be used as runtime-base for services

## Why ❔

As a workaround for dockerhub ratelimits

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

Rename workflows for runner and builder base

## Why ❔

Easier to find =)

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

Proper platform names for docker build action

## Why ❔

Docker documentation (which is linked in docker-build-action docs)
[points to non-working
reference](https://docs.docker.com/reference/cli/docker/buildx/build/#platform)

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
…ter-labs#2924)

## What ❔

Proper type of var for platforms in docker build action

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.

---------

Signed-off-by: Danil <[email protected]>
…labs#2926)

## What ❔

Move building images to zksync-runtime-base

## Why ❔

Workaround for dockerhub rate limits

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
🤖 I have created a release *beep* *boop*
---


##
[24.25.0](matter-labs/zksync-era@core-v24.24.0...core-v24.25.0)
(2024-09-19)


### Features

* (DB migration) Rename recursion_scheduler_level_vk_hash to
snark_wrapper_vk_hash
([matter-labs#2809](matter-labs#2809))
([64f9551](matter-labs@64f9551))
* add da clients
([matter-labs#2743](matter-labs#2743))
([9218612](matter-labs@9218612))
* attester committees data extractor (BFT-434)
([matter-labs#2684](matter-labs#2684))
([92dde03](matter-labs@92dde03))
* emit errors in prover API metrics
([matter-labs#2890](matter-labs#2890))
([2ac7cc5](matter-labs@2ac7cc5))
* **en:** Resume incomplete snapshot in snapshot creator in more cases
([matter-labs#2886](matter-labs#2886))
([f095b4a](matter-labs@f095b4a))
* make `to` address optional for transaction data
([matter-labs#2852](matter-labs#2852))
([8363c1d](matter-labs@8363c1d))
* **prover:** Optimize setup keys loading
([matter-labs#2847](matter-labs#2847))
([19887ef](matter-labs@19887ef))
* Selector generator tool
([matter-labs#2844](matter-labs#2844))
([b359b08](matter-labs@b359b08))
* **tee:** use hex serialization for RPC responses
([matter-labs#2887](matter-labs#2887))
([abe0440](matter-labs@abe0440))
* **utils:** Rework locate_workspace, introduce Workspace type
([matter-labs#2830](matter-labs#2830))
([d256092](matter-labs@d256092))
* **zk_toolbox:** Add external_node consensus support
([matter-labs#2821](matter-labs#2821))
([4a10d7d](matter-labs@4a10d7d))


### Bug Fixes

* count SECP256 precompile to account validation gas limit as well
([matter-labs#2859](matter-labs#2859))
([fee0c2a](matter-labs@fee0c2a))
* **en:** Fix connection starvation during snapshot recovery
([matter-labs#2836](matter-labs#2836))
([52f4f76](matter-labs@52f4f76))
* **eth_watch:** fix `get_events_inner`
([matter-labs#2882](matter-labs#2882))
([c957dd8](matter-labs@c957dd8))
* handling of HTTP 403 thrown by proxyd
([matter-labs#2835](matter-labs#2835))
([2d71c74](matter-labs@2d71c74))
* **state-keeper:** Restore processed tx metrics in state keeper
([matter-labs#2815](matter-labs#2815))
([4d8862b](matter-labs@4d8862b))
* **tee-prover:** fix deserialization of `std::time::Duration` in `envy`
config ([matter-labs#2817](matter-labs#2817))
([df8641a](matter-labs@df8641a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
## What ❔
- 30 GB of free disk space are no longer sufficient to run a testnet EN.
Upped the system requirements to 50 GB.
- State growth is normally used to refer to the growth of the state
tree, not of the historical state. What we have is historical state
pruning, not state pruning.
## What ❔

Bumps the `vm2` crate revision and updates new VM usage correspondingly.

## Why ❔

To keep the `vm2` dependency up to date and track possible regressions.

## Checklist


- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

Use precompiled `rocksdb` and `snappy` in the nix build.

## Why ❔

Speeds up compilation and is usually better maintained.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.

Signed-off-by: Harald Hoyer <[email protected]>
)

## What ❔

Add `/queue_report` endpoint, which will get the data about queue and
send it.

## Why ❔

To work with new autoscaler

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.

---------

Co-authored-by: EmilLuta <[email protected]>
It will allow us to announce the recommended default list of peers to
all ENs without manual intervention.
Fixes BFT-509.

---------

Co-authored-by: Bruno França <[email protected]>
## What ❔

- Allows to continue batch execution on divergence via new
`ShadowLenient` VM mode.
- Dumps VM state to logs and optionally a file on divergence.

## Why ❔

Allows to detect divergencies in multiple batches w/o blockers. The
dumped VM state will hopefully allow investigating divergencies locally,
although this logic isn't implemented yet.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
…tter-labs#2930)

## What ❔

In some places our sqlx queries are using string literals instead of
query macros. This PR changes this behaviour in places it is possible.

## Why ❔

To prevent possible SQL injections.
It also will cache the queries, which should make them faster.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
### Summary

This PR introduces a new component `circuit_prover`, which is multiple
WVGs & GPU prover running together, groupless. The changes are
non-destructive, old setup and new setup must work together in-tandem.

### What?

Circuit prover is a component that runs X WVGs alongside a GPU prover.
Making full use of CPUs on the GPU machine, WVGs as a component can be
removed altogether. Prover groups are not needed anymore. Based on
empiric testing we can (almost -- there will be follow-up fixes to make
it efficient) fully run everything on a single machine.

The current implementation can sunset the old setup. Current metrics
show that circuit prover is > 60% efficient than old one (but quirks are
needed for node proofs to unlock it -- will be treated as a follow-up).

The purpose is to have the `circuit_prover` deprecate old `prover_fri` &
`witness_vector_generator`.

### Why?

The changes will allow us to reduce our infrastructure footprint by ~2x
and fix plenty of issues we had in the past. Namely:
- fully decoupled of GCP
- better resource utilization & reduce costs
- reduce overall infrastructure needs (which solves the GPU
unavailability we've been facing)
- reduce complexity & other inefficiencies (no more prover groups!)
- and more

### Ask

We want to unblock folks running on AWS. This PR is done as is to speed
up release process on DevOps side, as it's the longest pole.

NOTE: This is the first PR out of a longer set of PRs.

Comments are more than welcome, but the following concerns will be
addressed in follow-up PRs and are out of scope for this PR:
- tracing implementation is subpar; in fact, I'm confident that most
metrics could be done via traces
- there's a lot of code duplication (both old/new prover, but runner
interface between new WVG & CP)
- tests
- concern separation between job scheduling & job execution
- job priority based on resource consumption
- other nits (such as no README, constants being hard-coded instead of
configuration, etc.)

### Reviewer suggestion

This is basically a merge between `prover_fri`,
`witness_vector_generation` and `JobProcessor`. Checking code alongside
should give you a better view of what's going on. Sorry for making this
hard. :/
## What ❔

Refactors `L1BatchParamsProvider`, in particular its construction.

## Why ❔

To have more intuitive DevEx.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
…s#2885)

## What ❔

Continues oneshot VM executor extraction by moving generic environment
types to the `zksync_vm_executor` crate.

## Why ❔

Makes it possible to use the VM executor outside the API server. E.g.,
it's now used in `zksync_node_consensus`.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
Discovered during testing Gateway integration (our own asserts from
query.rs started being triggered by our eth api implementation :D )

---------

Co-authored-by: perekopskiy <[email protected]>
## What ❔
Adding more information to the EN Grafana dashboards, which barely had
any.

## Why ❔
Better observability.

Fixes BFT-507
🤖 I have created a release *beep* *boop*
---


##
[24.26.0](matter-labs/zksync-era@core-v24.25.0...core-v24.26.0)
(2024-09-23)


### Features

* added seed_peers to consensus global config
([matter-labs#2920](matter-labs#2920))
([e9d1d90](matter-labs@e9d1d90))
* **circuit_prover:** Add circuit prover
([matter-labs#2908](matter-labs#2908))
([48317e6](matter-labs@48317e6))
* **prover:** Add endpoint to PJM to get queue reports
([matter-labs#2918](matter-labs#2918))
([2cec83f](matter-labs@2cec83f))
* **vm:** Do not panic on VM divergence
([matter-labs#2705](matter-labs#2705))
([7aa5721](matter-labs@7aa5721))
* **vm:** Extract oneshot VM executor – environment types
([matter-labs#2885](matter-labs#2885))
([a2d4126](matter-labs@a2d4126))


### Bug Fixes

* **api_server:** fix blob_gas length
([matter-labs#2673](matter-labs#2673))
([44a8f79](matter-labs@44a8f79))
* **eth-sender:** print better error message in case of missing blob
prices ([matter-labs#2927](matter-labs#2927))
([38fc824](matter-labs@38fc824))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
artmakh and others added 4 commits October 4, 2024 09:53
## What ❔

Ability to build zk-env with cuda not only from push to main branch

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk_supervisor fmt` and `zk_supervisor
lint`.
@gianbelinche gianbelinche changed the title Eigen DA Merge Main task: Eigen DA Merge Main Oct 4, 2024
@gianbelinche gianbelinche changed the title task: Eigen DA Merge Main chore: Eigen DA Merge Main Oct 4, 2024
perekopskiy and others added 7 commits October 7, 2024 07:02
## What ❔

Periodically fetch bridge addresses

## Why ❔

Addresses will be changed during gateway upgrade

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk_supervisor fmt` and `zk_supervisor
lint`.
## What ❔

Covers more `TxSender` functionality with unit tests.

## Why ❔

More test coverage is good. Also, it will help with new VM integration
(by running the added tests with a shadowed VM).

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Code has been formatted via `zk_supervisor fmt` and `zk_supervisor
lint`.
Configuration parameter for time_in_mempool_cap, cap for time_in_mempool
in eth-sender fee model + default values for parameter_a and parameter_b
for GasAdjuster
## What ❔

`fmt --check` wasn't returning an error code when failing
…bs#3016)

## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->
Remove `generate-sk` subcommand which doesn’t exist anymore.

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk_supervisor fmt` and `zk_supervisor
lint`.
## What ❔

Removes unit test files for old VM versions in the `multivm` crate.

## Why ❔

These tests are not built (not included into the module tree of the
crate), so they are just deadweight.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
Base automatically changed from da-eigen-implementation-concurrency to da-eigen-implementation October 7, 2024 16:15
gianbelinche and others added 3 commits October 7, 2024 14:24
## What ❔

Brushes up the `eth_signer` crate so that its API is easier to use
(e.g., it doesn't require an async runtime).

## Why ❔

Improved DevEx.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk_supervisor fmt` and `zk_supervisor
lint`.
gianbelinche and others added 8 commits October 7, 2024 14:55
…tter-labs#2994)

## What ❔

Prepares the new VM for use in the API server (without tracers):

- Fills in more statistics
- Covers more statistic fields in divergence checks and fixes the
corresponding divergence in `pubdata_published`
- Fixes a divergence if revert reaches the bootloader call frame
(happens in the call execution mode)
- Fixes a panic in `ShadowVm` if the transaction hash is not set and
makes `impl Debug for Transaction` non-panicking. (A hash is not set if
a transaction is converted from a call.)

## Why ❔

Part of preparations for integrating the new VM into the API server.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.

---------

Co-authored-by: Joonatan Saarhelo <[email protected]>
)

I don't know about other people's setup, but for me it is very flaky
with just 3s
Add a new metric to track custom base token to ETH ratio
Copy link

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juan518munoz juan518munoz merged commit d06b433 into da-eigen-implementation Oct 8, 2024
34 of 70 checks passed
@juan518munoz juan518munoz deleted the da-eigen-merged-main branch October 8, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.