Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paymaster params RLP encoding #137

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

IAvecilla
Copy link
Contributor

The previous encode was correct if the PaymasterParams was present but it failed in case of not having it because of an invalid length error. This change check for the paymaster params and encode them correctly but add an empty string to match with correct length.

Copy link
Contributor

@ischasny ischasny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing.

@IAvecilla IAvecilla merged commit ec7bd20 into main Sep 13, 2024
4 of 5 checks passed
@IAvecilla IAvecilla deleted the fix-paymaster-params-rlp-encode branch September 13, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants