-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Twitter release announcement #174
Feature: Twitter release announcement #174
Conversation
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
We can use it to simplify the git setup and GitHub operations. Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
So far, the releases of all packages have shown that the milestone descriptions are used very rarley. I also suggest not to use "tweet" here but something more general like "announcement" or "notice". If there is a new service or another hip provider tomorrow, then it would have to be changed. |
How would you format the announcement, when using labels?
I personally prefer having full control of the announcement, by simply updating the milestone description once rather than tracking down multiple PRs to add labels and making sure each PR has a proper title.
This implementation adds namespace Laminas\AutomaticReleases\Announcement\Contracts
interface Announcement
{
public function __toString(): string;
public static function fromMilestone(Milestone $milestone): self;
}
interface Publish
{
public function __invoke(Announcement $message): void;
} with the intention of adding discord, slack (via webhooks) later. That's why |
Right, it is limited but you also must count the characters if you write the message by hand. Short and concise titles can be used for new features and these can be added as first lines for the release notes. GitHub already use the first lines for tweets: <meta name="twitter:description" content="Release Notes for 4.5.1
4.5.x bugfix release (patch)
4.5.1
Total issues resolved: 0
Total pull requests resolved: 1
Total contributors: 1
Bug
124: Fixed deprecated null parameter in trim() call ..." /> https://github.com/laminas/laminas-code/releases/tag/4.5.1
I see no need for these channels, not for the Laminas project. |
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
No, the meta tag with the
I assumed the "Announcement" is something like eg; ^
That is not the point. I'm pointing out that the interfaces created the abstractions. I guess it's a no to adding |
Right, it is used in tweets, something else was not meant
Also right, but I think there is a misunderstanding here, because I am not against the implementation, only that so far individual text is very rarely used in the milestone descriptions. Therefore I suggest to improve the generation of the release notes which results in a better Twitter card. And one suggestion for this improvement is the use of a label for new features which can be added to issue reports and pull request and then rendered in the first lines of the milestone description. An individual text is then not necessarily needed because the Twitter card already covers everything important. However, this does not mean that the possibility to add an individual text should not be given.
Correct, it is already here on GitHub. |
this is why I chose milestone descriptions as a good candidate for storing the Twitter announcement, "so far individual text is very rarely used in the milestone descriptions.". (no BC)
the current "Twitter card" are you asking me to "improve" the output of if so, this patch is meant to automatically post tweets. out of scope, no?
cool, I'll set some time to learn more about that. (read: actions and or error logs expire on GitHub, per user/org level. fun.) |
closing, lost interest.
Asked to be nominated to help Maintainers. (ignored) Asked for input and feedback regarding issues and pull requests. (ignored) Contributors Time, Skills, and FREE Labor wasted. (PRs are ignored for months, then closed.)
|
This patch resolves #24 (supersedes #129), via the following changes:
abraham/twitteroauth
The tweet will be extracted from the milestone description if a
tweet
markdown code block matches:If one is not found, it will create a default tweet.