Skip to content

Commit

Permalink
qa: prefix generic tags with "v"
Browse files Browse the repository at this point in the history
Particularly with major tags, we need a prefix.
Minor tags work without it, but having the prefix on the generic tags makes it simpler to understand which tags are auto-generated.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
  • Loading branch information
weierophinney committed Feb 4, 2021
1 parent 2c428f8 commit da5fe7b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/actions/generate-tags/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ let major = semver.major(tag);
let minor = major + '.' + semver.minor(tag);

let tags = [
major,
minor,
'v' + major,
'v' + minor,
];

core.info(`Original tag: ${tag}`);
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- uses: actions/checkout@v2
name: Gather CI configuration
id: matrix
uses: laminas/laminas-ci-matrix-action@0
uses: laminas/laminas-ci-matrix-action@v0

qa:
name: QA Checks
Expand All @@ -52,7 +52,7 @@ jobs:
matrix: ${{ fromJSON(needs.matrix.outputs.matrix) }}
steps:
- name: ${{ matrix.name }}
uses: laminas/laminas-continuous-integration-action@0
uses: laminas/laminas-continuous-integration-action@v0
with:
job: ${{ matrix.job }}
```

0 comments on commit da5fe7b

Please sign in to comment.