🐛 Automatically add missing columns upon .standardize() if nullable is True
#2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
==========================================
+ Coverage 91.53% 91.56% +0.02%
==========================================
Files 64 64
Lines 9992 10001 +9
==========================================
+ Hits 9146 9157 +11
+ Misses 846 844 -2 ☔ View full report in Codecov by Sentry. |
falexwolf
changed the title
.standardize() if nullable is True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrameCurator.standardize()failed saying: "feature doesn't have a default value".featureisnullable,.standardize()will add columns and fill them withpd.NA.This PR adds a few more other tests of edge cases and makes fixes in the docs.