feat(rust): implement a ListingCatalog #3300
Draft
+284
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanghua
force-pushed
the
3290-catalog-rust-interface
branch
from
6a32543 to
f5347b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3300 +/- ##
==========================================
+ Coverage 78.81% 78.85% +0.03%
==========================================
Files 250 251 +1
Lines 91306 91461 +155
Branches 91306 91461 +155
==========================================
+ Hits 71963 72121 +158
+ Misses 16390 16376 -14
- Partials 2953 2964 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yanghua
force-pushed
the
3290-catalog-rust-interface
branch
from
f5347b5 to
1d308e0
Compare
|
Hi @westonpace I drafted a PR for discussion. About naming, some thoughts:
|
| fn list_datasets(&self, namespace: &Namespace) -> Vec<DatasetIdentifier>; | ||
|
|
||
| /// Create a new dataset in the catalog. | ||
| fn create_dataset( |
There was a problem hiding this comment.
I think using register_dataset interface to register an existed lance dataset is also needed.
yanghua
commented
Dec 27, 2024
| fn invalidate_dataset(&self, identifier: &DatasetIdentifier) -> Result<(), String>; | ||
|
|
||
| /// Register a dataset in the catalog. | ||
| fn register_dataset(&self, identifier: &DatasetIdentifier) -> Result<Dataset, String>; |
There was a problem hiding this comment.
Hi @SaintBacchus it's here
SaintBacchus
approved these changes
Dec 31, 2024
yanghua
changed the title
yanghua
force-pushed
the
3290-catalog-rust-interface
branch
from
8f2bec4 to
a1f3359
Compare
yanghua
commented
Jan 27, 2025
| } | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl Catalog for ListingCatalog { |
There was a problem hiding this comment.
@westonpace I implemented a simple version for discussion. Please take a look when you have time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.