-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Quality of Life improvements for Astra Component #6953
Open
deon-sanchez
wants to merge
38
commits into
main
Choose a base branch
from
lfoss-683-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into lfoss-683-1
CodSpeed Performance ReportMerging #6953 will improve performances by 28.44%Comparing Summary
Benchmarks breakdown
|
…into lfoss-683-1
- Improved AstraDB component's embedding provider link with better accessibility attributes - Updated Vector Store RAG starter project JSON with formatted configuration - Refined UI text and link presentation for better user experience
- Implemented visual indicator (*) for required node parameters - Updated custom parameter title rendering to show required status - Enhanced UI to provide clearer input requirements
…into lfoss-683-1
…into lfoss-683-1
…into lfoss-683-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of helper texts, embedding provider options, and database information in the
astradb.py
file, as well as updates to the frontend components to support these backend changes.Backend changes:
src/backend/base/langflow/components/vectorstores/astradb.py
: Added helper text for embedding generation providers and updated the handling of thedimension
field based on the embedding provider. [1] [2]src/backend/base/langflow/components/vectorstores/astradb.py
: Includedorg_id
in the database list and initialization methods. [1] [2]src/backend/base/langflow/components/vectorstores/astradb.py
: Adjusted the embedding provider options and added logic to set thedimension
field based on the selected provider. [1] [2] [3] [4]Frontend changes:
src/frontend/src/CustomNodes/GenericNode/components/NodeDialogComponent/index.tsx
: Added required field indicator in the dialog.src/frontend/src/components/core/dropdownComponent/index.tsx
: Added support for displaying helper text in dropdown components and updated the exclusion of metadata keys. [1] [2] [3] [4] [5]src/frontend/src/components/core/parameterRenderComponent/index.tsx
: PassedhelperText
to the parameter render component. [1] [2]src/frontend/src/customization/components/custom-parameter.tsx
: Added required field indicator in custom parameter titles. [1] [2]src/frontend/src/utils/stringManipulation.ts
: Added a utility function to convert strings to HTML. [1] [2]