Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typos Across Backend and Frontend Codebase #6972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ENUMERA8OR
Copy link

@ENUMERA8OR ENUMERA8OR commented Mar 9, 2025

This pull request fixes multiple typographical errors across the codebase, improving code readability and documentation accuracy.

Changes:
Corrected spelling errors in variable names, comments, and documentation (e.g., "sucessors" → "successors", "retrive" → "retrieve", "ouptut" → "output").
Fixed minor inconsistencies in class and function descriptions.
Updated UI-related text constants for better clarity.
These changes do not alter functionality but enhance maintainability.

Adding More details for Better Logging:
This pull request includes various typo corrections and minor improvements across multiple files in the project. The changes aim to improve the readability and accuracy of comments, documentation, and variable names.

Typo Corrections:

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 9, 2025
Copy link

codspeed-hq bot commented Mar 9, 2025

CodSpeed Performance Report

Merging #6972 will improve performances by 39.65%

Comparing ENUMERA8OR:main (4ad53af) with main (a5a8227)

Summary

⚡ 2 improvements
✅ 17 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 9.1 ms 8 ms +13.78%
test_cancel_nonexistent_build 13.7 ms 9.8 ms +39.65%

@edwinjosechittilappilly edwinjosechittilappilly changed the title Fix Typos Across Backend and Frontend Codebase Fix: Typos Across Backend and Frontend Codebase Mar 10, 2025
@edwinjosechittilappilly
Copy link
Collaborator

Good One!

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request fixes typographical errors across both backend and frontend code, improving overall readability and documentation accuracy.

  • Corrects several spelling mistakes in code and comments.
  • Updates language and UI text constants for clarity.
  • Refines comments and descriptions to better reflect intended meanings.

Reviewed Changes

File Description
src/backend/base/langflow/components/vectorstores/vectara_rag.py Replaced "vie" with "via" in language list
src/frontend/src/constants/constants.ts Fixed typos in UI text constants and error messages
src/backend/base/langflow/components/data/url.py Corrected "retrive" to "retrieve" in a description string
scripts/ci/pypi_nightly_tag.py Updated comment text regarding version tagging
src/backend/base/langflow/components/vectorstores/astradb.py Fixed "correspoding" to "corresponding" in a description string
src/backend/base/langflow/components/vectorstores/redis.py Fixed misspelling of "documents.txt"
src/backend/tests/conftest.py Corrected misspelled keyword "retun" to "return"
src/backend/base/langflow/base/data/base_file.py Corrected comment typo to "Supersedes"
src/backend/base/langflow/components/processing/filter_data_values.py Corrected typo "comparision" to "comparison"
src/backend/base/langflow/components/vectorstores/vectara_self_query.py Fixed spelling error in info string ("Vectore" to "Vector")
src/backend/base/langflow/graph/graph/base.py Corrected typo "sucessors" to "successors"
src/backend/tests/unit/graph/graph/test_utils.py Fixed comment typo "shoud" to "should"
src/backend/base/langflow/components/tools/astradb.py Fixed typo "correspoding" to "corresponding"
src/backend/base/langflow/services/tracing/langfuse.py Corrected misspelling "actualy" to "actually"
src/backend/base/langflow/graph/graph/ascii.py Renamed variables from "vertexes" to "vertices" for consistency
src/backend/base/langflow/schema/data.py Corrected comment typo "atributes" to "attributes"
src/backend/tests/unit/base/tools/test_toolmodemixin.py Fixed comment contraction "Shouldnt" to "Shouldn't"
src/frontend/src/controllers/API/queries/files/use-download-files.ts Fixed typo "convertion" to "conversion"

Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

scripts/ci/pypi_nightly_tag.py:53

  • [nitpick] The updated comment 'if DONE' is unclear and might be misleading. Consider revising this comment to accurately reflect the condition under which 'v' is prepended to the version string.
+    # Prepend "v" to the version, if DONE.

@@ -36,7 +36,7 @@ class VectaraRagComponent(Component):
"rus",
"tur",
"fas",
"vie",
"via",
Copy link
Preview

Copilot AI Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language code was changed from 'vie' to 'via'. Please double-check if 'via' is the intended code (ISO 639-3 for Vietnamese is 'vie').

Suggested change
"via",
"vie",

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@edwinjosechittilappilly
Copy link
Collaborator

cc. @carlosrcoelho @ogabrielluiz

@edwinjosechittilappilly
Copy link
Collaborator

@lucaseduoli Can you also take a look into the .ts files, I believe some of the changes in TS files have breaking changes.
can you confirm it?

@edwinjosechittilappilly
Copy link
Collaborator

@ENUMERA8OR, please run the make format and make lint commands to fix and track formatting and linting issues. can fix/track the format and lint issues.

@ENUMERA8OR
Copy link
Author

@ENUMERA8OR, please run the make format and make lint commands to fix and track formatting and linting issues. can fix/track the format and lint issues.

Sure, please give me some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants