Update .env.example to fix MILVUS_URI default value #13140
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
codingjaguar
commented
Feb 2, 2025
codingjaguar
commented
Feb 2, 2025
codingjaguar
commented
Feb 2, 2025
|
We fix the CI in #13142, please rebase the origin/main :) |
The MILVUS_URI with localhost is not reachable from another docker container. Changed to the special DNS name `host.docker.internal` to fix the problem. See detailed issue report in https://discord.com/channels/1160323594396635310/1335159004598370376/1335281419240607884
dosubot
bot
added
size:L
codingjaguar
force-pushed
the
codingjaguar-patch-1
branch
from
8d9a827 to
04d1af4
Compare
dosubot
bot
added
size:XS
@crazywoola Done. Could you give it a review? Thanks! |
|
@crazywoola Another unrelated question: I saw Now full text search in Milvus is mature with 2.5.4. Is that feasible to update the default config to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The MILVUS_URI with localhost is not reachable from another docker container. Changed to the special DNS name
host.docker.internalto fix the problem.See detailed issue report in
https://discord.com/channels/1160323594396635310/1335159004598370376/1335281419240607884
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods