Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ast] dictionaries in external dependency #10378

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

jaumeortola
Copy link
Member

@jaumeortola jaumeortola commented Mar 8, 2024

Everything seems okay here. We can do the merge. @esbardu

@jaumeortola jaumeortola merged commit 8ee12bc into master Mar 12, 2024
3 checks passed
@jaumeortola jaumeortola deleted the ast-update-dict branch March 12, 2024 15:44
@esbardu
Copy link
Contributor

esbardu commented Mar 12, 2024

Thanks a lot for all work here, @jaumeortola. From now on, every time I want to update files (or have a group of changes to update them all together), I understand that I'll have to do it in a branch of my ast-pos-dict repository and, if everything goes well, I'll merge it with the main branch of my repository, right? And is this change automatic for LanguageTool or does a new release have to be made in Sonatype? In the latter case, should I contact you to make the update?

@jaumeortola
Copy link
Member Author

does a new release have to be made in Sonatype?

A new release in Sonatype is needed.

Usually, you do this:

  • build a new binary file
  • build a new version of the dependency and test it locally (changing the version in LanguageTool, but not committing yet)
  • if all tests pass, publish the new version in Sonatype
  • commit the new version number to LT

You can contact me to publish the new version on Sontaype. If you want to be more independent, you can open your account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants