Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Removed "temp_off" from rule ID:COLOCACAO_PRONOMINAL_EM_O_SENDO and ID:COLOCACAO_PRONOMINAL_COM_ATRATOR_COMPLEXO #11111

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Dec 13, 2024

Removed "temp_off" from rules.

Summary by CodeRabbit

  • New Features
    • Updated grammar rules for Portuguese, enhancing the accuracy of grammar checks.
    • Adjusted the default activation status of specific rules to improve user experience.

…and ID:COLOCACAO_PRONOMINAL_COM_ATRATOR_COMPLEXO
Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Walkthrough

The changes in this pull request involve the modification of two grammar rules in the Portuguese language module of LanguageTool. Specifically, the default="temp_off" attribute has been removed from the rule COLOCACAO_PRONOMINAL_COM_ATRATOR_COMPLEXO and the rule group COLOCACAO_PRONOMINAL_EM_O_SENDO in the grammar.xml file. This alteration indicates a change in the default activation status of these rules within the grammar checking framework.

Changes

File Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml Removed default="temp_off" attribute from the rule COLOCACAO_PRONOMINAL_COM_ATRATOR_COMPLEXO and the rule group COLOCACAO_PRONOMINAL_EM_O_SENDO.

Possibly related PRs

Suggested reviewers

  • jaumeortola
  • p-goulart

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)

Line range hint 12893-12928: Consider documenting these grammar rule changes

Both rules being enabled by default represent a significant change in Portuguese grammar checking behavior. Consider:

  1. Updating the Portuguese grammar documentation to reflect these newly activated rules
  2. Adding a changelog entry to inform users about the stricter pronoun placement checking
  3. Monitoring user feedback after deployment to ensure these rules don't generate false positives
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5dfe21a and bb15717.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (2 hunks)
🔇 Additional comments (2)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (2)

Line range hint 12924-12928: Verify the impact of enabling this rule group by default

The removal of default="temp_off" from this rule group means it will now actively enforce proclisis in constructions with "em o sendo". While this change is intentional per the PR objectives, we should verify its readiness for default activation.

Let's check for any related discussions and test coverage:

✅ Verification successful

Let me check the test cases for this rule to verify its readiness.


Let me check the complete rule definition and its examples to better understand its implementation.


Rule is well-implemented and ready for default activation

The rule is properly implemented with:

  • Clear pattern matching for "em" + optional preposition + gerund constructions
  • Proper filter class (PortugueseProclisisFilter) for handling suggestions
  • Well-defined message explaining the grammar rule
  • Multiple test examples demonstrating correct and incorrect usage
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for discussions and test coverage for this rule

# Search for issues/PRs mentioning this rule
gh search issues "COLOCACAO_PRONOMINAL_EM_O_SENDO" --repo languagetool-org/languagetool

# Check for test cases
rg -l "COLOCACAO_PRONOMINAL_EM_O_SENDO" --type xml

Length of output: 228


Script:

#!/bin/bash
# Search for test cases in the XML files
rg -B 5 -A 5 "COLOCACAO_PRONOMINAL_EM_O_SENDO" --type xml

# Check if there are any unit tests for this rule
fd ".*Test.*\.java" languagetool-language-modules/pt/src/test/ --exec rg -l "COLOCACAO_PRONOMINAL_EM_O_SENDO" {}

Length of output: 1597


Script:

#!/bin/bash
# Get the complete rule definition including examples
rg -B 2 -A 15 'COLOCACAO_PRONOMINAL_EM_O_SENDO.*name=' --type xml languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml

Length of output: 1120


Line range hint 12893-12897: Verify the impact of enabling this rule by default

The removal of default="temp_off" means this rule for pronoun placement with complex attractors will now be active by default. While the change aligns with the PR objectives, we should ensure this won't unexpectedly affect users.

Let's check for any related discussions or issues about this rule:

@marcoagpinto marcoagpinto merged commit e991a32 into master Dec 14, 2024
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20241213_2322 branch December 14, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant