Cb changes 20250110 #11181
Cb changes 20250110 #11181
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request involves multiple updates to language resource files across different language modules. The changes primarily focus on expanding vocabulary and linguistic resources for German and English languages. The modifications include adding new words, phrases, proper nouns, and grammatical terms to various spelling, suggestion, and specific case files. These additions enhance the language tool's ability to recognize and process a wider range of terms, names, and linguistic constructs. Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/hunspell/spelling.txt (1)
65827-65827: Consider adding French pronunciation guidance for "Crémant"Since this is a French loanword (marked with #name), consider adding a pronunciation hint to help users with the French accent.
languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/multitoken-suggest.txt (1)
Line range hint
3155-3164: Review person name formattingPerson names follow the standard format with /S suffix where appropriate:
- "James Henry Greathead/S"
- "Dschûnel Kebrit"
- "Al Bashir/S #name"
- "Golden Bachelor/S #name"
- "Dommaraju Gukesh/S #name"
- "Darryl Jones"
The #name tag is used inconsistently - consider adding it to all person names for better categorization.
🧰 Tools
🪛 LanguageTool
[misspelling] ~3125-~3125: Possible spelling mistake found.
Context: ... Koh Lanta/S Ko Phangan/S Koh Phangan/S Koh Pha Ngan/S Ko Pha-ngan/S Kloster Seeon/S Pak Cho...(EN_MULTITOKEN_SPELLING_THREE)
languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/multiwords.txt (1)
8055-8056: Consider adding countable forms for the vegetable terms.While both spelling variants "pak choi" and "bok choy" are correctly tagged as uncountable (NN:U), consider also adding their countable forms (NN/NNS) since these vegetables can be counted (e.g., "two bok choys").
Apply this diff to add the countable forms:
pak choi NN:U +pak choi NN +pak chois NNS bok choy NN:U +bok choy NN +bok choys NNSlanguagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/remote-rule-filters.xml (1)
2017-2024: Consider enhancing the pattern specificity and test coverage.The pattern could be made more specific to target only verb contractions, and additional examples could help cover edge cases.
Consider this enhancement:
<rule><!--5--> <pattern> - <token regexp="yes">[a-zäöüß]+</token> + <token regexp="yes" postag="VER:.*">[a-zäöüß]+</token> <token>'</token> <token>s</token> </pattern> <example correction="">Mir <marker>geht's</marker> auch gut</example> + <example correction="">Wie <marker>steht's</marker> mit dir?</example> + <example correction="">Da <marker>gibt's</marker> nichts zu sehen.</example> </rule>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
languagetool-core/src/main/resources/org/languagetool/resource/spelling_global.txt(1 hunks)languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/hunspell/spelling.txt(1 hunks)languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/multitoken-suggest.txt(1 hunks)languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/remote-rule-filters.xml(1 hunks)languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/multiwords.txt(1 hunks)languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/specific_case.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (13)
languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/hunspell/spelling.txt (2)
65823-65829: LGTM! The new entries follow the correct format and grammatical annotations.The additions maintain consistency with German compound word formation rules and include appropriate grammatical markers (/S for plural, /A for adjectives).
65828-65829: Verify medical terminology consistencyThe terms "Kotzreiz" and "Kotzreize" are medical terms. Ensure they align with standard German medical terminology.
✅ Verification successful
Medical terms "Kotzreiz" and "Kotzreize" verified as standard German medical terminology
The terms follow proper German medical compound formation and are consistent with other medical *reiz compounds in the dictionary that describe physical urges/stimuli (e.g., Juckreiz, Niesreiz).
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other medical terms in the dictionary to verify consistency rg -i "reiz|reflex" "languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/"Length of output: 69469
Script:
#!/bin/bash # Search for the exact terms and surrounding context echo "=== Searching for Kotzreiz terms ===" rg -B2 -A2 "Kotzreiz" "languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/" echo -e "\n=== Searching for medical compounds with reiz ===" rg "([A-Z][a-z]+reiz|[A-Z][a-z]+reize)" "languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/" echo -e "\n=== Searching for Kotz- compounds ===" rg "Kotz[a-z]+" "languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/"Length of output: 87993
languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/multitoken-suggest.txt (6)
Line range hint
3132-3138: Ensure proper tagging of English phrasesThe English phrases are correctly tagged with #eng:
- "Sexiest Man Alive/S"
- "Sexiest Woman Alive/S"
- "Embedded Systems"
- "Emerging Technology"
- "Emerging Technologies"
The /S suffix is appropriately used for countable nouns.
🧰 Tools
🪛 LanguageTool
[misspelling] ~3125-~3125: Possible spelling mistake found.
Context: ... Koh Lanta/S Ko Phangan/S Koh Phangan/S Koh Pha Ngan/S Ko Pha-ngan/S Kloster Seeon/S Pak Cho...(EN_MULTITOKEN_SPELLING_THREE)
Line range hint
3139-3146: Verify gender-specific performer termsThe performer entries follow proper German grammar patterns:
- "Low Performer/SN" (masculine)
- "Low Performerin" (feminine singular)
- "Low Performerinnen" (feminine plural)
- "High Performer/SN" (masculine)
- "High Performerin" (feminine singular)
- "High Performerinnen" (feminine plural)
The suffixes and feminine forms are correctly structured.
🧰 Tools
🪛 LanguageTool
[misspelling] ~3125-~3125: Possible spelling mistake found.
Context: ... Koh Lanta/S Ko Phangan/S Koh Phangan/S Koh Pha Ngan/S Ko Pha-ngan/S Kloster Seeon/S Pak Cho...(EN_MULTITOKEN_SPELLING_THREE)
Line range hint
3147-3149: Check capitalization consistency of Hebrew phraseThe Hebrew congratulatory phrase is included in both capitalized and lowercase forms:
- "Masel tov"
- "masel tov"
This is good practice to support both variants.
🧰 Tools
🪛 LanguageTool
[misspelling] ~3125-~3125: Possible spelling mistake found.
Context: ... Koh Lanta/S Ko Phangan/S Koh Phangan/S Koh Pha Ngan/S Ko Pha-ngan/S Kloster Seeon/S Pak Cho...(EN_MULTITOKEN_SPELLING_THREE)
Line range hint
3150-3154: Verify Indonesian condiment namingThe Indonesian sambal entries use consistent formatting:
- "Sambal Ulek/S"
- "Sambal Oelek/S"
Both spelling variants are provided with proper /S suffix for pluralization.
🧰 Tools
🪛 LanguageTool
[misspelling] ~3125-~3125: Possible spelling mistake found.
Context: ... Koh Lanta/S Ko Phangan/S Koh Phangan/S Koh Pha Ngan/S Ko Pha-ngan/S Kloster Seeon/S Pak Cho...(EN_MULTITOKEN_SPELLING_THREE)
Line range hint
3165-3174: Check Latin theological termsThe Latin theological terms are properly formatted without suffixes:
- "vocatio externa"
- "vocatio interna"
- "vocatio spiritualis"
These terms are correctly left uninflected as they follow Latin grammar.
🧰 Tools
🪛 LanguageTool
[misspelling] ~3125-~3125: Possible spelling mistake found.
Context: ... Koh Lanta/S Ko Phangan/S Koh Phangan/S Koh Pha Ngan/S Ko Pha-ngan/S Kloster Seeon/S Pak Cho...(EN_MULTITOKEN_SPELLING_THREE)
3128-3131: Verify consistency of Chinese vegetable naming variantsThe entries for Chinese cabbage variants should be standardized:
- "Pak Choi/S"
- "Pak Choy/S"
- "Pok Choi/S"
Having multiple spelling variants is good for user flexibility, but consider adding cross-references or marking preferred spellings.
Run this script to check for any other variants:
✅ Verification successful
Chinese vegetable naming variants are consistent and complete
The multiple spelling variants are consistently formatted with the plural suffix /S, and no additional unexpected variants were found in the codebase. The presence of "pak choi" in the English resource validates this as the primary form, while the variations accommodate common alternative spellings.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other potential variants of these terms rg -i "p[ao][ck] ?ch[oi][iy]"Length of output: 486
languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/specific_case.txt (1)
5616-5620: Verify proper noun capitalizationThe new entries follow proper capitalization rules:
- "Pacific Palisades" (place name)
- "Banco BPM" (company name)
- "Herbert Quandt" (person name)
- "Susanne Klatten" (person name)
- "Stefan Quandt" (person name)
All entries maintain appropriate capitalization for proper nouns.
Run this script to check for any inconsistent capitalization:
✅ Verification successful
Capitalization consistency verified
All new entries maintain consistent and correct capitalization across the entire codebase, including language-specific modules and core resources.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for potential case inconsistencies of these terms rg -i "pacific palisades|banco bpm|quandt"Length of output: 1823
languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/multiwords.txt (1)
8054-8054: LGTM! Proper noun tagging is consistent with other place names.The NNP tag for "Pacific Palisades" follows the established pattern for geographical names in this file.
languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/remote-rule-filters.xml (1)
2017-2024: The rule implementation for handling contractions looks good.The pattern correctly matches German contractions (e.g., "geht's") with:
- A word sequence (
[a-zäöüß]+)- An apostrophe (
')- The letter 's'
The example "Mir geht's auch gut" appropriately demonstrates the usage.
languagetool-core/src/main/resources/org/languagetool/resource/spelling_global.txt (2)
27020-27023: LGTM on the remaining entries.The other entries (orchestras, locations, people, and music companies) are correctly spelled and appropriately capitalized.
27020-27023: Verify the line numbering format.Some entries have line numbers (27020-27023) while others don't. This inconsistency in formatting could cause issues with file maintenance and future updates.
Let's check if this is a consistent pattern in the file:
| @@ -27017,6 +27017,10 @@ Sergiu Comissiona | |||
| Andrew Huberman | |||
| BBC Symphony Orchestra | |||
| Philharmonia Orchestra | |||
| Docusign | |||
There was a problem hiding this comment.
Fix company name capitalization.
"Docusign" should be "DocuSign" (the official company name with correct capitalization).
-Docusign
+DocuSign📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Docusign | |
| DocuSign |
tiff
force-pushed
the
cb-changes-20250110
branch
from
549ae0e to
5c4438e
Compare
Summary by CodeRabbit
Spelling and Language Improvements
Vocabulary Enhancements