[pt] Added APs to rules ID:GENERAL_NUMBER_AGREEMENT_ERRORS and GENERAL_VERB_AGREEMENT_ERRORS #11184
Conversation
…L_VERB_AGREEMENT_ERRORS
WalkthroughThe pull request introduces two new antipattern elements in the Portuguese language grammar rules file. These antipatterns define specific token combinations and postag patterns to improve grammar checking accuracy. The first antipattern focuses on verb-related tokens, while the second targets a more complex combination of determiners, pronouns, and verb forms. These additions aim to enhance the precision of grammatical rule detection in Portuguese language processing. Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (2)
9133-9141: LGTM! Antipattern effectively handles "X de nós" constructions.The antipattern correctly prevents false positives in cases where plural determiners/pronouns followed by "de nós" take a third-person plural verb. The examples provided are grammatically correct and illustrative.
Consider adding an example with a different determiner to show the pattern's full scope, such as:
- "Alguns de nós preferem estudar à noite."
- "Vários de nós trabalham remotamente."
4386-4391: Well-structured placement of antipatterns.The antipatterns are correctly positioned:
- The verb sequence antipattern is placed globally, benefiting all subrules
- The "X de nós" antipattern is specifically placed in GENERAL_VERB_AGREEMENT_ERRORS where it's most relevant
Also applies to: 9133-9141
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)
4386-4391: LGTM! Antipattern correctly handles complex verb constructions.The antipattern effectively prevents false positives in sequences containing a verb followed by a gerund and a past participle. The example sentence "Parece-me teres bem compreendido..." demonstrates valid usage.
Let's verify if there are similar patterns in the codebase that might need this antipattern:
✅ Verification successful
Antipattern is unique and doesn't conflict with existing rules
The similar pattern found in style.xml serves a different purpose (style checking for specific phrases with 'estar') and won't conflict with our antipattern for verb+gerund+participle constructions. The antipattern is safe to implement.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for similar verb patterns in other rules rg -l "postag='V.+'.+postag='RG'" "languagetool-language-modules/pt/src/main/resources/"Length of output: 188
Script:
#!/bin/bash # Get context around the verb+gerund patterns in style.xml rg -B2 -A2 "postag='V.+'.+postag='RG'" "languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml"Length of output: 420
Antipatterns to fix false positives.
Summary by CodeRabbit