[pt] Improved rule ID:PHD_TESE_PROCURAR_PROVAR_PROVARA

[marcoagpinto]

Fixed false positives.

Summary by CodeRabbit

• Documentation
  • Enhanced language rule configuration for Portuguese grammar
  • Added more example sentences to illustrate rule application
  • Updated grammatical exception conditions to include additional part-of-speech tags

[coderabbitai]

Walkthrough

The pull request modifies the Portuguese language module's style rule XML configuration. The changes involve updating the <exception> element's postag attribute to include an additional part-of-speech tag (RN), which expands the rule's matching conditions. Five new <example> entries have been added to provide more context and illustrate the rule's application, specifically focusing on the phrase "não quero saber" in various grammatical contexts.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml	- Updated <exception> element's postag attribute from PD.+ to `PD.+

Possibly related PRs

• [pt] Removed "temp_off" from rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10870: Modifies the same XML file with changes to language rule exceptions
• [pt-PT] Removed "temp_off" from rule ID:VERBO_PRONOMINAL_DE_V3 #10912: Similar XML configuration modifications for language rules
• [pt-PT] Removed "temp_off" from rule ID:VERBO_PARA_PRONOME_PESSOAL_V2 #10933: Changes to the XML file focusing on rule modifications and exceptions

Suggested reviewers

• jaumeortola

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 999bff5 and 4e2f77c.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (java-kotlin)

🔇 Additional comments (2)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (2)

10760-10764: LGTM! Good test coverage with examples.

The new examples effectively demonstrate various contexts where the rule should not trigger, providing good coverage for the false positive fixes.

---

10745-10745: LGTM! Verify the impact on false positives.

The addition of the RN tag to the exception pattern is well-formed and aligns with the PR objective of fixing false positives.

Let's verify the impact by checking for similar patterns in other rules:

✅ Verification successful

The addition of the RN tag is correctly scoped and doesn't require changes in other files.

The pattern modification is specific to the PHD_TESE_PROCURAR_PROVAR_PROVARA rule in style.xml. Other occurrences of PD.+ tags in the Portuguese language files serve different grammatical purposes and don't require similar updates.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for similar patterns to ensure consistency
rg -l "postag='PD.+" "languagetool-language-modules/pt/src/main/resources/"

Length of output: 446

---

Script:

#!/bin/bash
# Search for context around PD postag patterns in all files
echo "=== Searching for related patterns in style.xml ==="
rg -B 5 -A 5 "postag='PD.+" "languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml"

echo -e "\n=== Searching for related patterns in pt-PT/grammar.xml ==="
rg -B 5 -A 5 "postag='PD.+" "languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/grammar.xml"

echo -e "\n=== Searching for related patterns in pt-PT/style.xml ==="
rg -B 5 -A 5 "postag='PD.+" "languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml"

echo -e "\n=== Searching for related patterns in grammar.xml ==="
rg -B 5 -A 5 "postag='PD.+" "languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml"

Length of output: 16453

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.