Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] improve rules #11191

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[en] improve rules #11191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...language-modules/en/src/main/resources/org/languagetool/resource/en/hunspell/spelling.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,7 @@ devesting
robotic
robotics
periotic
meromorphic
tympanic
tympanum
tympanums
Expand Down
22 changes: 18 additions & 4 deletions languagetool-language-modules/en/src/main/resources/org/languagetool/rules/en/grammar.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106814,18 +106814,32 @@ The accident victim died from her injuries.
</rule>
<rule id="AT_THE_JOB" name="Collocation: at/on the job">
<!-- Created by Nicholas Walker (Bokomaru), 2018-05-16. Edited by MFU 2019-03-13 -->
<antipattern>
<token>shot</token>
<token>at</token>
</antipattern>
<antipattern>
<token regexp="yes" inflected="yes">remain|stay</token>
<token>at</token>
</antipattern>
<pattern>
<token>at<exception scope="previous" inflected="yes">look</exception></token>
<token>the</token>
<token>job</token>
<token chunk_re="E-NP.*">job</token>
</pattern>
<message>The usual collocation is <suggestion>on the job</suggestion> or <suggestion>at work</suggestion>.</message>
<example correction="on the job|at work">He does personal stuff <marker>at the job</marker>.</example>
<example>He does personal stuff <marker>on the job</marker>.</example>
<example>I'd like to invite you to <marker>look at the job</marker> I've posted.</example>
<example>How did it go at the job interview?</example>
<example>I was supposed to fly out at 7, but had nothing to do at the job fair and was forced to check out of my room by 12.</example>
</rule>
<rule id="ANALYSIS_ABOUT" name="Collocation: analysis about/of">
<!-- Created by Nicholas Walker (Bokomaru), 2018-05-16 -->
<antipattern>
<token skip="-1">what</token>
<token>about</token>
</antipattern>
<pattern>
<token>analysis</token>
<token>about</token>
Expand Down Expand Up @@ -106856,11 +106870,11 @@ The accident victim died from her injuries.
<rule id="SPEND_IT_FOR" name="Collocation: spend it for/on">
<antipattern><!-- https://www.lexico.com/definition/for_good -->
<token>for</token>
<token>good</token>
<token regexp="yes">good|sure|(you|him|her|them|me)(self|selves)?</token>
</antipattern>
<!-- Created by Nicholas Walker (Bokomaru), 2018-05-16 -->
<pattern>
<token inflected='yes'>spend</token>
<token inflected='yes' chunk_re=".-VP">spend</token>
<token>it</token>
<token>for</token>
</pattern>
Expand Down Expand Up @@ -106897,7 +106911,7 @@ The accident victim died from her injuries.
<rule id="WHAT_WE_CALL_2" name="Collocation: we call/you would call">
<!-- Created by Nicholas Walker (Bokomaru), 2018-05-16 -->
<pattern>
<token inflected="yes" regexp='yes'>be|m</token>
<token inflected="yes">be</token>
<marker>
<token>not</token>
<token>what</token>
Expand Down
Loading