[pt-PT] Added rule to rulegroup id:COLOQUIALISMOS_PT_PT #11195
Conversation
WalkthroughThe pull request introduces a new style rule in the Portuguese language module of LanguageTool. The rule targets the colloquial expression "de um dia para o outro" and provides formal alternatives for more precise language usage. The rule is currently set to Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (2)
2102-2110: Rule pattern looks good but consider adding antipatterns.The pattern correctly matches the colloquial expression "de um dia para o outro". However, to improve accuracy and reduce false positives, consider adding antipatterns for cases where this expression might be used literally rather than colloquially.
<antipattern> <!-- For literal time references --> <token>mudou</token> <token>literalmente</token> <token>de</token> <token>um</token> <token>dia</token> <token>para</token> <token>o</token> <token>outro</token> </antipattern>
2117-2119: Example demonstrates correct usage but could be expanded.The example correctly demonstrates the rule's application. However, consider adding more examples to cover different contexts and verb tenses.
<example correction='de forma súbita|subitamente|de maneira repentina|repentinamente|num curto intervalo de tempo'>Tudo mudou <marker>de um dia para o outro</marker>.</example> <example correction='de forma súbita|subitamente|de maneira repentina|repentinamente|num curto intervalo de tempo'>A empresa cresceu <marker>de um dia para o outro</marker>.</example>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)
2111-2116: LGTM! Suggestions provide good formal alternatives.The suggestions offer appropriate formal alternatives that maintain the semantic meaning while improving the style:
- "de forma súbita"
- "subitamente"
- "de maneira repentina"
- "repentinamente"
- "num curto intervalo de tempo"
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)
2102-2119: Good implementation of the colloquialism rule!The rule effectively identifies and suggests formal alternatives for the colloquial expression "de um dia para o outro". The implementation follows the established pattern of other colloquialism rules in the file.
Consider these enhancements:
- Add a URL reference to a reputable source (like ciberduvidas.iscte-iul.pt) documenting this colloquialism
- Add more examples showing variations of the expression to better test the rule's coverage
<rule default='temp_off'> <pattern> <token>de</token> <token>um</token> <token>dia</token> <token>para</token> <token>o</token> <token>outro</token> </pattern> <message>&colloquialism_msg;</message> <suggestion>de forma súbita</suggestion> <suggestion>subitamente</suggestion> <suggestion>de maneira repentina</suggestion> <suggestion>repentinamente</suggestion> <suggestion>num curto intervalo de tempo</suggestion> + <url>https://ciberduvidas.iscte-iul.pt/...</url> <short>Coloquialismo</short> <example correction='de forma súbita|subitamente|de maneira repentina|repentinamente|num curto intervalo de tempo'>A Ana fê-lo <marker>de um dia para o outro</marker>.</example> + <example correction='de forma súbita|subitamente|de maneira repentina|repentinamente|num curto intervalo de tempo'>Ele mudou <marker>de um dia para o outro</marker>.</example> </rule>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
A colloquialism rule for pt-PT.
Summary by CodeRabbit