-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Removed "temp_off" from two rules #11205
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (1)
4118-4118
: Consider adding a changelog entry for enabling these style rules.Since you're enabling two previously disabled style rules that affect formal writing suggestions, it would be helpful to:
- Add a changelog entry explaining why these rules are now considered stable enough for default activation
- Document any known limitations or specific use cases where these rules are most beneficial
Also applies to: 4287-4287
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (python)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (2)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (2)
4118-4118
: Verify testing coverage before enabling the rule by default.The removal of
default='temp_off'
will activate this formal language suggestion rule by default. Since this is a style rule suggesting formal alternatives for "gastar", please ensure it has been thoroughly tested to avoid false positives in contexts where "gastar" is appropriate.Run this script to check for any related test cases:
4287-4287
: Document the rationale for enabling the simplification rule.The removal of
default='temp_off'
will activate this simplification rule by default. While simplifying "Substantivo + que vem" to "próxim(ao)(s) + substantivo" can improve readability, please:
- Ensure thorough testing to avoid false positives
- Consider documenting why these rules are now being enabled by default
Run this script to check for any related test cases and reported issues:
Removed "temp_off".
Summary by CodeRabbit
default='temp_off'
attribute from two language rule configurations in Portuguese language module