Lt marcoagpinto 20250123 1304

[marcoagpinto]

@susanaboatto

Here it is!

Summary by CodeRabbit

• New Features

  • Added new language style rules for Portuguese to improve formal language usage
  • Introduced guidelines for replacing "gastar" with more formal alternatives like "despender" and "desembolsar" in financial contexts

• Refactor

  • Reorganized Portuguese language style rules to enhance linguistic precision

[coderabbitai]

Walkthrough

This pull request involves modifications to Portuguese language style rules in the LanguageTool project. Specifically, the changes relate to a rule group focused on replacing the verb "gastar" with more formal alternatives like "despender" and "desembolsar" in financial contexts. The modifications include adding new rules in the Portuguese-specific style XML file for European Portuguese, which aim to enhance the formality of language usage by suggesting more precise terminology.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml	Added new rule group gastar → despender/desembolsar with two rules: 1. Rule for replacing "gastar" in financial contexts 2. Rule for handling past participle of "gastar"
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml	Removed existing rule group GASTAR_DESPENDER_DESEMBOLSAR and its associated rules

Possibly related PRs

• [pt] Added formal rule ID:GASTAR_DESPENDER_DESEMBOLSAR #11201: Introduces a new rule group for gastar → despender/desembolsar
• [pt] Fixed and removed "temp_off" from rule ID:PARA_NADA_DESNECESSARIAMENTE #10908: Modifies rule PARA_NADA_DESNECESSARIAMENTE in the same style XML file
• [pt] Added rule ID:DEMASIADO_INVARIAVEL #10905: Contributes to improving Portuguese grammar rules

Suggested reviewers

• susanaboatto

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[marcoagpinto]

@susanaboatto

It failed a check.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)

3424-3433: Consider adding antipatterns for common idiomatic expressions.

While the current implementation works well, it could benefit from additional antipatterns to handle common idiomatic expressions using "gastar" that shouldn't be flagged.

For example:

<antipattern>
    <token inflected='yes'>gastar</token>
    <token>saliva</token>
</antipattern>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a65a28a and 62c1a6d.

📒 Files selected for processing (2)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1 hunks)
• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (0 hunks)

💤 Files with no reviewable changes (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml

🔇 Additional comments (4)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (4)

3401-3403: LGTM! Well-structured rule group with clear purpose.

The rule group is well-organized and properly documented with comments.

---

3404-3416: LGTM! Good use of antipatterns to avoid false positives.

The antipatterns effectively prevent the rule from triggering on legitimate uses of "gastos" as a noun.

---

3417-3423: Comprehensive coverage of financial terms.

The pattern includes an extensive list of financial and monetary terms, making the rule robust and widely applicable. The list covers various currencies, financial instruments, and monetary concepts.

---

3434-3455: LGTM! Proper handling of past participle forms.

The second rule correctly handles past participle forms with auxiliary verbs while maintaining the same comprehensive financial terms coverage.

[marcoagpinto]

@jaumeortola

I noticed you have commits with the "CodeQL" test failed.

Is it safe for me to merge this pull request?

Thanks!

[jaumeortola]

@marcoagpinto I think that CodeQL test is unrelated to rule tests, and you can merge the PR. @SteVio89 can confirm?

[marcoagpinto]

@jaumeortola

Merged!

Thanks!