-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Added exceptions to rule ID:QUE_É-SÃO_NC-ADJ_COMO-POR #11224
Conversation
WalkthroughThe pull request introduces changes to the XML configuration for the Portuguese language module by adding an Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)
7857-7857
: Formatting and Readability Check on New LineThe insertion at line 7857 appears to be an intentional extra line that improves readability. Please verify that this formatting is consistent with the overall file style.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (2)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (2)
7860-7865
: New Antipattern Block: Validate Regex Patterns & ExampleA new
<antipattern>
block has been introduced to capture linking verbs and related terms. Please ensure that:
- The token
<token>que</token>
is specific enough and does not lead to false positives considering that "que" is highly frequent in Portuguese.- The regular expressions for linking verbs (e.g.,
andar|continuar|estar|ficar|parecer|permanecer|ser|tornar-se|virar|viver
) and for additional terms (e.g.,fen[ôó]meno|sensação|moda|hit|referência|mania|sucesso
) are accurate and do not match unintended patterns.- The example provided clearly demonstrates the intended rule behavior and its edge cases.
7866-7869
: Additional Antipattern Block: Ensure Proper XML Closure and Schema ConformanceThis block uses
<antipattern>
with tokens defined viapostag
attributes. Please verify that:
- The antipattern element is correctly closed later in the file (as the diff snippet does not show the closing tag).
- The XML structure remains well-formed and adheres to the project's schema.
Added exceptions.
Summary by CodeRabbit