Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] Dictionary additions #9610

Merged
merged 2 commits into from
Nov 7, 2023
Merged

[fr] Dictionary additions #9610

merged 2 commits into from
Nov 7, 2023

Conversation

LucieSteib
Copy link
Collaborator

During GEMA annotations, some words were found missing (see also here).

@LucieSteib LucieSteib changed the title [fr] Dictionary addition [fr] Dictionary additions Nov 6, 2023
@LucieSteib LucieSteib requested a review from GillouLT November 6, 2023 16:30
@@ -3066,3 +3066,8 @@ Simone Louise de Pinet de Borde des Forest; Z f s
Thérèse Raquin; Z e s
Tonino Benacquista; Z m s
plug and play; N m s
Paul Signac; Z m s
tegenaria domestica; N f s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😨

@GillouLT
Copy link
Collaborator

GillouLT commented Nov 6, 2023

LGTM! You can merge after resolving the conflict :)

Yverdon
Paul Signac
IST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder: please add abbreviations and uncommon names to the ignore.txt (there are a couple more below)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiff They are here on purpose, people use these as words quite commonly :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK Got it

@LucieSteib LucieSteib merged commit d7503ec into master Nov 7, 2023
@LucieSteib LucieSteib deleted the fr/dictionary branch November 7, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants