Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Fixed 2 FPs and removed "temp_off" from rule ID:QUALQUER_QUE_SEJA #9617

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

marcoagpinto
Copy link
Member

Heya, Susana and Pedro,

Here are the whole results:
https://internal1.languagetool.org/regression-tests/via-http/2023-11-06/pt-BR_full/result_style_QUALQUER_QUE_SEJA%5B1%5D.html

I have removed the two false positives in this pull request:

<example>Maria é uma pessoa muito espontânea; explode por qualquer que seja o motivo.</example>
<example>...heiro que mais me remete à minha mãe é o do perfume dela: sempre forte, com presença e notas doces (qualquer que seja o do momento... rs).</example>

@susanaboatto
Copy link
Collaborator

I think we can tone tag this rule as formal. At least for pt-BR, it would fit into that category.

@marcoagpinto
Copy link
Member Author

Heya, @susanaboatto

I have added the "formal" to it.

@marcoagpinto
Copy link
Member Author

Heya, @susanaboatto and @p-goulart

I have 7 open pull requests.

Should I wait until they are all approved, or shall I continue adding new ones?

Thanks!

@p-goulart
Copy link
Collaborator

I have 7 open pull requests.
Should I wait until they are all approved, or shall I continue adding new ones?

Sorry about that, I've been focussing on the dictionary migration, but I'll have a look at your PRs now.

@marcoagpinto marcoagpinto merged commit 4eafbc9 into master Nov 14, 2023
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20231107_1328 branch November 14, 2023 19:02
@marcoagpinto
Copy link
Member Author

Thank you, @p-goulart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants