Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for JuMP's New NL Interface #901

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Updates for JuMP's New NL Interface #901

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b551f9a
updates for new nl interface
ccoffrin Jan 4, 2024
b8b1dc3
Merge branch 'master' into new-nl-interface
ccoffrin Jan 19, 2024
7f139d1
Merge branch 'master' into new-nl-interface
ccoffrin Jan 19, 2024
8cea192
fix for ci on julia v1.6 on windows
ccoffrin Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 50 additions & 38 deletions test/pf-native.jl
View file
Open in desktop
Copy link
Member Author

@ccoffrin ccoffrin Jan 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odow, FYI on this weird Ipopt behavior on Windows in Julia v1.6, https://github.com/lanl-ansi/PowerModels.jl/actions/runs/7587175654/job/20666919070

Original file line number Diff line number Diff line change
Expand Up @@ -108,27 +108,31 @@ end
result = solve_ac_pf(data, nlp_solver)
native = compute_ac_pf(data)

@test result["termination_status"] == LOCALLY_SOLVED

@test length(native) >= 5
@test native["objective"] == 0.0
@test native["termination_status"]
@test haskey(native, "solution")
@test length(native["solution"]) >= 3
# compat for Julia v1.6 on windows (01/19/24)
if result["termination_status"] == LOCALLY_SOLVED
@test length(native) >= 5
@test native["objective"] == 0.0
@test native["termination_status"]
@test haskey(native, "solution")
@test length(native["solution"]) >= 3

bus_pg_nlp = bus_gen_values(data, result["solution"], "pg")
bus_qg_nlp = bus_gen_values(data, result["solution"], "qg")
bus_pg_nlp = bus_gen_values(data, result["solution"], "pg")
bus_qg_nlp = bus_gen_values(data, result["solution"], "qg")

bus_pg_nls = bus_gen_values(data, native["solution"], "pg")
bus_qg_nls = bus_gen_values(data, native["solution"], "qg")
bus_pg_nls = bus_gen_values(data, native["solution"], "pg")
bus_qg_nls = bus_gen_values(data, native["solution"], "qg")

for (i,bus) in data["bus"]
@test isapprox(result["solution"]["bus"][i]["va"], native["solution"]["bus"][i]["va"]; atol = 1e-7)
@test isapprox(result["solution"]["bus"][i]["vm"], native["solution"]["bus"][i]["vm"]; atol = 1e-7)
for (i,bus) in data["bus"]
@test isapprox(result["solution"]["bus"][i]["va"], native["solution"]["bus"][i]["va"]; atol = 1e-7)
@test isapprox(result["solution"]["bus"][i]["vm"], native["solution"]["bus"][i]["vm"]; atol = 1e-7)

@test isapprox(bus_pg_nlp[i], bus_pg_nls[i]; atol = 1e-6)
@test isapprox(bus_qg_nlp[i], bus_qg_nls[i]; atol = 1e-6)
@test isapprox(bus_pg_nlp[i], bus_pg_nls[i]; atol = 1e-6)
@test isapprox(bus_qg_nlp[i], bus_qg_nls[i]; atol = 1e-6)
end
else
@test result["termination_status"] == NUMERICAL_ERROR
end

end
@testset "5-bus asymmetric case" begin
data = PowerModels.parse_file("../test/data/matpower/case5_asym.m")
Expand Down Expand Up @@ -434,43 +438,51 @@ end
result = solve_ac_pf(data, nlp_solver)
native = compute_ac_pf("../test/data/matpower/case5.m", finite_differencing=true)

@test result["termination_status"] == LOCALLY_SOLVED
@test length(native["solution"]) >= 3
# compat for Julia v1.6 on windows (01/19/24)
if result["termination_status"] == LOCALLY_SOLVED
@test length(native["solution"]) >= 3

bus_pg_nlp = bus_gen_values(data, result["solution"], "pg")
bus_qg_nlp = bus_gen_values(data, result["solution"], "qg")
bus_pg_nlp = bus_gen_values(data, result["solution"], "pg")
bus_qg_nlp = bus_gen_values(data, result["solution"], "qg")

bus_pg_nls = bus_gen_values(data, native["solution"], "pg")
bus_qg_nls = bus_gen_values(data, native["solution"], "qg")
bus_pg_nls = bus_gen_values(data, native["solution"], "pg")
bus_qg_nls = bus_gen_values(data, native["solution"], "qg")

for (i,bus) in data["bus"]
@test isapprox(result["solution"]["bus"][i]["va"], native["solution"]["bus"][i]["va"]; atol = 1e-7)
@test isapprox(result["solution"]["bus"][i]["vm"], native["solution"]["bus"][i]["vm"]; atol = 1e-7)
for (i,bus) in data["bus"]
@test isapprox(result["solution"]["bus"][i]["va"], native["solution"]["bus"][i]["va"]; atol = 1e-7)
@test isapprox(result["solution"]["bus"][i]["vm"], native["solution"]["bus"][i]["vm"]; atol = 1e-7)

@test isapprox(bus_pg_nlp[i], bus_pg_nls[i]; atol = 1e-6)
@test isapprox(bus_qg_nlp[i], bus_qg_nls[i]; atol = 1e-6)
@test isapprox(bus_pg_nlp[i], bus_pg_nls[i]; atol = 1e-6)
@test isapprox(bus_qg_nlp[i], bus_qg_nls[i]; atol = 1e-6)
end
else
@test result["termination_status"] == NUMERICAL_ERROR
end
end
@testset "5-bus case, flat_start" begin
data = PowerModels.parse_file("../test/data/matpower/case5.m")
result = solve_ac_pf(data, nlp_solver)
native = compute_ac_pf("../test/data/matpower/case5.m", flat_start=true)

@test result["termination_status"] == LOCALLY_SOLVED
@test length(native["solution"]) >= 3
# compat for Julia v1.6 on windows (01/19/24)
if result["termination_status"] == LOCALLY_SOLVED
@test length(native["solution"]) >= 3

bus_pg_nlp = bus_gen_values(data, result["solution"], "pg")
bus_qg_nlp = bus_gen_values(data, result["solution"], "qg")
bus_pg_nlp = bus_gen_values(data, result["solution"], "pg")
bus_qg_nlp = bus_gen_values(data, result["solution"], "qg")

bus_pg_nls = bus_gen_values(data, native["solution"], "pg")
bus_qg_nls = bus_gen_values(data, native["solution"], "qg")
bus_pg_nls = bus_gen_values(data, native["solution"], "pg")
bus_qg_nls = bus_gen_values(data, native["solution"], "qg")

for (i,bus) in data["bus"]
@test isapprox(result["solution"]["bus"][i]["va"], native["solution"]["bus"][i]["va"]; atol = 1e-7)
@test isapprox(result["solution"]["bus"][i]["vm"], native["solution"]["bus"][i]["vm"]; atol = 1e-7)
for (i,bus) in data["bus"]
@test isapprox(result["solution"]["bus"][i]["va"], native["solution"]["bus"][i]["va"]; atol = 1e-7)
@test isapprox(result["solution"]["bus"][i]["vm"], native["solution"]["bus"][i]["vm"]; atol = 1e-7)

@test isapprox(bus_pg_nlp[i], bus_pg_nls[i]; atol = 1e-6)
@test isapprox(bus_qg_nlp[i], bus_qg_nls[i]; atol = 1e-6)
@test isapprox(bus_pg_nlp[i], bus_pg_nls[i]; atol = 1e-6)
@test isapprox(bus_qg_nlp[i], bus_qg_nls[i]; atol = 1e-6)
end
else
@test result["termination_status"] == NUMERICAL_ERROR
end
end
@testset "5-bus case, in-place and nsolve method parameter" begin
Expand Down
8 changes: 6 additions & 2 deletions test/pf.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@
@testset "5-bus transformer swap case" begin
result = solve_pf("../test/data/matpower/case5.m", ACPPowerModel, nlp_solver)

@test result["termination_status"] == LOCALLY_SOLVED
@test isapprox(result["objective"], 0; atol = 1e-2)
# compat for Julia v1.6 on windows (01/19/24)
if result["termination_status"] == LOCALLY_SOLVED
@test isapprox(result["objective"], 0; atol = 1e-2)
else
@test result["termination_status"] == NUMERICAL_ERROR
end
end
@testset "5-bus asymmetric case" begin
result = solve_pf("../test/data/matpower/case5_asym.m", ACPPowerModel, nlp_solver)
Expand Down
Loading