Code cleanup + Bugfix #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsgrattan
approved these changes
Dec 5, 2024
src/qca/utils/algo_utils.py
Outdated
| algo_name='GSEE', | ||
| fname=circuit_name, | ||
| is_extrapolated=is_extrapolated, | ||
| numsteps=nsteps, |
There was a problem hiding this comment.
should we choose a default naming scheme for all functions and standardize that? as far as I'm aware, we have numsteps, total_steps, and nsteps and potentially others.
There was a problem hiding this comment.
nsteps is used the most so ill proceed with that one
zain2864
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Other than the comments George and I have, it looks good. I think we just need to add many test cases to make sure handling new functions and some old that were not tested before. Maybe we should start log warnings for when inputs are invalid or unexpected behaviors occurs.
zain2864
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on cleaning up some of the code, specifically, the interfaces for generating resource estimates. Additionally, this PR is focused on fixing up some bugs w/ respect to GSEE that was uncovered after PR #61 was merged in. The bugs just broke the handshake between circuit generation + resource estimation so that was handled as well.