[FEATURE] Feature/orm3 #580
Conversation
TomHAnderson
force-pushed
the
feature/orm3
branch
from
8314e5c to
62a7b04
Compare
|
All unit tests pass |
| @@ -12,7 +12,7 @@ class MetaDataManager extends Manager | |||
| */ | |||
| public function getDefaultDriver() | |||
| { | |||
| return 'annotations'; | |||
| return 'xml'; | |||
There was a problem hiding this comment.
Isnt the attributes driver a more natural default driver? Symfony uses this as default.
There was a problem hiding this comment.
The most technically correct answer is xml. However most users of Doctrine use the easy way out and use annotations, now attributes. If the goal of this project is to provide the most simple possible Doctrine metadata configuration then attributes is the right answer. Given the history of this project recommending annotations, I agree attributes would be the simple, easy, and best default.
|
@eigan There are so many differences between my PR and 2.0 that I recommend a new branch, 3.0.x, be created. I've got more work to do on this, too. I intend to
Since these two goals are separate from the goal of this PR, I request you create that new branch right away, knowing it won't pass actions checks right away. |
|
@eigan the base has been changed. This PR is ready to merge to 3.0 |
| "doctrine/orm": "^2.14", | ||
| "doctrine/persistence": "^3", | ||
| "php": "^8.1", | ||
| "doctrine/cache": "^2.2", |
There was a problem hiding this comment.
Do you really still need Doctrine Cache?
There was a problem hiding this comment.
Removing it, and the unit tests still pass.
There was a problem hiding this comment.
This change will be in a future PR. I'm waiting to see how much support this community will give my work on the library.
|
I have two other PRs, each building on this one, that I'll queue up to review once this is merged. What's your normal timeline to get refactoring work like this merged into a new branch? |
|
Moved to #582 |
This PR adapts to ORM 3 and DBAL 4.
This is ready to merge to 3.0. Unit tests all passed, but a handful had to be skipped to allow for more time.