Add Signal channel #106
Open
Add Signal channel #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Add Discord channel" (laravel-notification-channels#14) Update README.md chore: update instructions chore: update readme docs: fork repo correction fix: update documentation Add files via upload Create src folder Create Exceptions folder Delete Exceptions Create Delete Create config folder Create delete Upload Signal files Upload file Create delete Add files via upload Add files via upload Delete Delete Delete delete Delete delete Delete test Delete signal-notification-channel.php Add files via upload Delete delete
Open
atymic
reviewed
Aug 12, 2020
atymic
requested changes
Aug 12, 2020
src/SignalChannel.php
Outdated
| } | ||
|
|
||
| if (!$result->isSuccessful()) { | ||
| $symfonyerror = new ProcessFailedException($result); |
There was a problem hiding this comment.
Shouldn't we pass a string, not another exception object here?
Fix code comment Co-authored-by: atymic <[email protected]>
Add config options, function types, additional tests. Removed flattening. Add .gitignore.
Not needed
atymic
reviewed
Aug 19, 2020
atymic
reviewed
Aug 19, 2020
atymic
reviewed
Aug 19, 2020
atymic
reviewed
Aug 19, 2020
atymic
reviewed
Aug 19, 2020
Fix indenting, remove env usage, fix spacing
Added additional tests
Fix sprintf usage
Add type hints
|
@tehCh0nG still happy to do this? If so i will re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the mass commits. I wasn't able to get them to squash.