Changes to make the examples run on Fresh Install #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a couple of things I had to change to get the repo to run on my fresh install on my machine (also an intel machine, not an M series).
thread_execution_widthis now deprecated and causes compiler errors. All references to it have been removed, and thestorearray has been reindexed.brewinstall paths have changed from/opt/homebrew/opt/to/usr/local/opt/Improvements/non-required changes I made
tasks.jsonfile to be json compliant so I couldjqit while trying to work out a bug that was actually just invoking a target that relied on relative paths from the wrong directory.Let me know if my changes sound reasonable, or if you would like to only let through some/a modification to them. Also, I would recommend adding a note about the launch targets displaying program output to the Debug Console (at least on my config) because that was very non-obvious to me.