Fixed ISSUE #571

laruence · May 19, 2022 · 5a0e57a · 5a0e57a
1 parent 9acee7a
commit 5a0e57a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tests/issue420.phpt b/tests/issue420.phpt
@@ -32,7 +32,7 @@ PHP
 
 $app = new Yaf_Application($config);
 $req = new Yaf_Request_Simple();
-$req->setControllerName('Foo_Bar');
+$req->setControllerName('Foo_Bar', false);
 var_dump($req->getControllerName());
 $req->setControllerName('index');
 $req->setActionName('func');

diff --git a/yaf_request.c b/yaf_request.c
@@ -1024,8 +1024,8 @@ PHP_METHOD(yaf_request, setModuleName) {
 		} else {
 			if (request->module) {
 				zend_string_release(request->module);
-				request->module = zend_string_copy(module);
 			}
+			request->module = zend_string_copy(module);
 		}
 	}
 
@@ -1050,8 +1050,8 @@ PHP_METHOD(yaf_request, setControllerName) {
 		} else {
 			if (request->controller) {
 				zend_string_release(request->controller);
-				request->controller = zend_string_copy(controller);
 			}
+			request->controller = zend_string_copy(controller);
 		}
 	}
 
@@ -1076,8 +1076,8 @@ PHP_METHOD(yaf_request, setActionName) {
 		} else {
 			if (request->action) {
 				zend_string_release(request->action);
-				request->action = zend_string_copy(action);
 			}
+			request->action = zend_string_copy(action);
 		}
 	}