Remove IO.blocking from array copy in S3 client. #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeifW
commented
Nov 13, 2024
| Async[F].blocking { | ||
| val bs = resp.asByteArray() | ||
| val len = bs.length | ||
| if (len < 0) None else Some(Chunk(unsafeWrapArray(bs)*)) |
There was a problem hiding this comment.
Also, why are we checking to see if the array size is negative? What would that even mean? This SO post says that can't happen: https://stackoverflow.com/a/11530038/283260
Should this just always return Some?
There was a problem hiding this comment.
Pushed a second commit removing this length check.
added 2 commits
November 13, 2024 12:14
* Also remove the array copy - using `.asByteArrayUnsafe` instead of `.asByteArray` to return the original byte array without making a copy of it. FS2 doesn't mutate the byte array afaict, and this `readFileMultipart` method returns a `fs2.Stream[F, Byte]` - the caller isn't going to be able to mutate those Bytes. * Also removed the `Monad.ifM`. `ifM(pure(x))(t, f)` is the same as `if (x) t else false`. * Construct the `Chunk`s from byte arrays in a more direct fashion.
Consolidate two subsequent `.flatMap`s into one.
LeifW
force-pushed
the
remove_blocking_and_array_copy
branch
from
db2d22e
to
b7d78a3
Compare
LeifW
commented
Nov 13, 2024
| Async[F].pure((Option.empty[ETag], Option.empty[Checksum], Option.empty[PartId])) | ||
| ) | ||
| cancelUpload(uploadId) *> ( | ||
| if (uploadEmptyFiles) uploadEmptyFile.map(eTag => Option(eTag.eTag)) |
There was a problem hiding this comment.
Could also do these two lines w/ like a OptionT.whenF(uploadEmptyFiles)(uploadEmptyFile), etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the array copy - using
.asByteArrayUnsafeinstead of.asByteArrayto return the original byte array without making a copy of it. FS2 doesn't mutate the byte array afaict, and thisreadFileMultipartmethod returns afs2.Stream[F, Byte]- the caller isn't going to be able to mutate those Bytes.Also removed the
Monad.ifM.ifM(pure(x))(t, f)is the same asif (x) t else f.Construct the
Chunks from byte arrays in a more direct fashion.