-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uploadEmptyFiles
Configuration to S3.uploadFile
#1293
Open
rodrigo-molina
wants to merge
13
commits into
laserdisc-io:main
Choose a base branch
from
rodrigo-molina:uploadFile-avoid-empty-files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add uploadEmptyFiles
Configuration to S3.uploadFile
#1293
rodrigo-molina
wants to merge
13
commits into
laserdisc-io:main
from
rodrigo-molina:uploadFile-avoid-empty-files
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `uploadEmptyFiles` boolean configuration for the `S3.uploadFile` method, defaulting to `false`. Key updates: 1. **Signature Consistency:** - Both `uploadFile` and `uploadFileMultipart` now return `Pipe[F, Byte, Option[ETag]]`. - Both methods support skipping empty files when `uploadEmptyFiles` is disabled. 2. **Breaking Changes:** - The return type of `uploadFile` is updated from `Pipe[F, Byte, ETag]` to `Pipe[F, Byte, Option[ETag]]`. - The `awsRequestModifier` argument position has been changed to align with the `uploadFileMultipart` signature, now appearing after the `uploadEmptyFiles` parameter.
Let me know if you'd prefer to avoid the breaking changes. If so, we can keep the existing uploadFile method unchanged and introduce a new method with a different name for the updated implementation. |
…y across method signatures. The parameters awsRequestModifier, requestModifier, and modifier are now uniformly named awsRequestModifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
uploadEmptyFiles
boolean configuration for theS3.uploadFile
method, defaulting tofalse
.Key updates:
Signature Consistency:
uploadFile
anduploadFileMultipart
now returnPipe[F, Byte, Option[ETag]]
.uploadEmptyFiles
is disabled.Breaking Changes:
uploadFile
is updated fromPipe[F, Byte, ETag]
toPipe[F, Byte, Option[ETag]]
.awsRequestModifier
argument position has been changed to align with theuploadFileMultipart
signature, now appearing after theuploadEmptyFiles
parameter.awsRequestModifier
,requestModifier
, andmodifier
are now uniformly namedawsRequestModifier
.